792813 - Fill in sessionConstants.h

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Eric Rescorla (:ekr)]

Ehugg,

This list wasn't updated.

Comment 1

[Ethan Hugg [:ehugg]]

Attachment: Fix feature list in sessionConstants.h

Comment 2

[Ethan Hugg [:ehugg]]

Comment on attachment 663015 [details] [diff] [review]
Fix feature list in sessionConstants.h


I moved the feature_names list into ccapi.h to be next to the enum list and updated its values.

I would be nice to have a clever way at compile-time to ensure that cc_feature_names[] gets initialized to exactly CC_FEATURE_MAX + 1 in size.

Comment 3

[Ethan Hugg [:ehugg]]

Attachment: Fix feature list in sessionConstants.h

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 663027 [details] [diff] [review]
Fix feature list in sessionConstants.h


Also found a bug with cc_msg_names.  PR_STATIC_ASSERT is my new friend.

Comment 5

[Eric Rescorla (:ekr)]

Comment on attachment 663027 [details] [diff] [review]
Fix feature list in sessionConstants.h

Review of attachment 663027 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/core/includes/ccapi.h
@@ +327,5 @@
> +
> +/* This checks at compile-time that the cc_msg_names list
> + * is the same size as the cc_msgs_t enum
> + */
> +PR_STATIC_ASSERT(sizeof(cc_msg_names) / sizeof(char *) == CC_MSG_MAX + 1);

You probably want to use PR_ARRAY_SIZE() here instead of the explicit sizeof

Comment 6

[Ethan Hugg [:ehugg]]

Attachment: Fix feature list in sessionConstants.h

Comment 7

[Ethan Hugg [:ehugg]]

Comment on attachment 663133 [details] [diff] [review]
Fix feature list in sessionConstants.h


Pushed to Alder: https://hg.mozilla.org/projects/alder/rev/9aaa4d60325c