Closed
Bug 792823
Opened 12 years ago
Closed 12 years ago
[b2g-bluetooth] BluetoothOppManager prototype
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: echou, Assigned: echou)
References
Details
(Whiteboard: [LOE:S])
Attachments
(2 files, 5 obsolete files)
We need a basic implementation of BluetoothOppManager, including registering OPP service.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #663000 -
Flags: review?(kyle)
Updated•12 years ago
|
Attachment #663000 -
Flags: review?(kyle) → review+
Comment 2•12 years ago
|
||
Assuming this is the end of our service additions for v1, we might want to remove the unused constants for the time being, just to clean up the warnings.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #663000 -
Attachment is obsolete: true
Assignee | ||
Comment 4•12 years ago
|
||
Please note that SendFile, StopSendingFile and ReceiveSocketData will be implemented in another issue because they are all related to OBEX protocol.
Attachment #663370 -
Flags: review?(kyle)
Updated•12 years ago
|
blocking-basecamp: ? → +
Comment 5•12 years ago
|
||
Comment on attachment 663370 [details] [diff] [review] patch 2: v1: BluetoothOppManager interface and prototype Review of attachment 663370 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/BluetoothOppManager.cpp @@ +11,5 @@ > +#include "BluetoothServiceUuid.h" > + > +USING_BLUETOOTH_NAMESPACE > + > +static BluetoothOppManager* sInstance = nullptr; Make this a RefPtr. Since it's inheriting UnixSocketConsumer it'll get RefCounted from there, and bad, afternoon eating things will happen if we don't do this. (Also: Change HfpManager to refcounted) @@ +74,5 @@ > + } > + > + nsRefPtr<BluetoothReplyRunnable> runnable = aRunnable; > + > + nsresult rv = bs->CloseSocket(this, runnable); Using the new socket stuff, we can just call close on ourselves. No need to pull a service. ::: dom/bluetooth/BluetoothOppManager.h @@ +35,5 @@ > + * process. At the end, the application will get a system message > + * indicating that te process is complete, then it can either call > + * Disconnect() to close RFCOMM connection or start another file-sending > + * thread via calling SendFile() again. > + */ Since we're explaining things there, might want to add something about sending progress as a system message too?
Attachment #663370 -
Flags: review?(kyle)
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #663364 -
Attachment is obsolete: true
Assignee | ||
Comment 7•12 years ago
|
||
* Added more comments * Passed a BlobParent* variable in SendFile() * Disconnect => void Disconnect()
Attachment #663370 -
Attachment is obsolete: true
Attachment #665453 -
Flags: review?(kyle)
Comment 8•12 years ago
|
||
Comment on attachment 665453 [details] [diff] [review] patch 2: v2: BluetoothOppManager interface and prototype Review of attachment 665453 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/BluetoothOppManager.cpp @@ +15,5 @@ > + > +USING_BLUETOOTH_NAMESPACE > +using namespace mozilla::ipc; > + > +static nsRefPtr<BluetoothOppManager> sInstance = nullptr; Just a RefPtr, actually, not an nsRefPtr. We aren't an XPCOM object... yet. :)
Attachment #665453 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 9•12 years ago
|
||
Nit fixed. Used nsAutoPtr instead of nsRefPtr to hold sInstance.
Attachment #665453 -
Attachment is obsolete: true
Assignee | ||
Comment 10•12 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=e2f2327be683
Assignee | ||
Comment 11•12 years ago
|
||
Replace nsRefPtr with RefPtr
Attachment #665798 -
Attachment is obsolete: true
Assignee | ||
Comment 12•12 years ago
|
||
"Try" again: https://tbpl.mozilla.org/?tree=Try&rev=0010bc06f156
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9946c7e4dd92 https://hg.mozilla.org/integration/mozilla-inbound/rev/5ce162e8bb47
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9946c7e4dd92 https://hg.mozilla.org/mozilla-central/rev/5ce162e8bb47
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•