Closed Bug 792845 Opened 8 years ago Closed 8 years ago
Scan Code With Extended Flat() returns without extended flag
WARNING: GetScanCodeWithExtendedFlat() returns without extended flag: file c:/proj/firefox/widget/windows/../../../mozilla-central/widget/windows/KeyboardLayout.cpp, line 554 spam in debug builds when I just hold down the control key. Fairly clean Windows 7 install with latest updates, debug m-c build.
Pretty sure this can just go away; if the NativeKey isn't extended, we don't need to set the flag, right? So we shouldn't print the warning... and is it useful to print it on < VISTA if mIsExtended?
Assignee: nobody → vladimir
Attachment #663246 - Flags: review?(jmathies)
Comment on attachment 663246 [details] [diff] [review] remove this warning Masayuki a better reviewer for this. He's authored all our overhauled keyboard handling.
Attachment #663246 - Flags: review?(jmathies) → review?(masayuki)
Comment on attachment 663246 [details] [diff] [review] remove this warning Ah, it's my mistake. I'd like to add NS_ASSERTION(), but it's not so urgent. I'll do it later. So, just removing it is okay for now.
Attachment #663246 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/02e75979ee3b Should this have a test?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Don't think so, it just nukes an assertion that was incorrectly-written in the first place (there's no reason to assert the condition as written, so nothing to test).
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.