792846 - SystemMessageInternal.js fails if one of the message receiver is closed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

If you open the dialer and then close it manually you won't receive calls anymore.

E/GeckoConsole(  105): [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/SystemMessageInternal.js" line: 82}]


This is a regression from bug 777206. Adding a simple try/cacth around the content of the broadcast message fix the issue but it seems like one of the listener of the message should have been removed from the list where it has not been.

Comment 1

[Andrew Overholt [:overholt]]

Gregor, can you take this?

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Gregor, do you wait for a review or are you going to do a cleaner fix that relies on unregistering listeners by sending a message when the process is closed / crash.

Comment 4

[Gregor Wagner [:gwagner]]

(In reply to Vivien Nicolas (:vingtetun) from comment #3)
> Gregor, do you wait for a review or are you going to do a cleaner fix that
> relies on unregistering listeners by sending a message when the process is
> closed / crash.

So the problem is that we never unregister any message listeners because of bug 793361. so the only clean solution is bug 777508. philikon is working on it but we might want to use the workaround as well.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 663553 [details] [diff] [review]
patch

Review of attachment 663553 [details] [diff] [review]:
-----------------------------------------------------------------

I don't like the workaround but I can live with it until there is a proper fix. Can you add a comment in the code explaining that this should be removed once the other bugs lands?

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f0b50af1051

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f0b50af1051