792890 - Fix JS-wrapping for callback interfaces to comply with the spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per spec, we should be "wrapping" callback interfaces to the underlying JS object, not double-wrapping in an XPCWrappedNative as we do now.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix JS-wrapping of callback interfaces to just return the underlying JS object. are several changes here:

1) When wrapping a callback interface object for JS, just extract the
   underlying JSObject from inside it and hand that object out.

2) Flag callback interface descriptors as "not concrete" (only matters
   for cases when they have constants on the interface object) and not
   wrappercached (will catch bugs if someone tries to treat them as a
   Gecko object).

3) Fix a preexisting bug in sequence wrapping where we'd try to
   JS_DefineElement twice if we were wrapping a null value for a
   sequence of nullable interface objects.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 663060 [details] [diff] [review]
Fix JS-wrapping of callback interfaces to just return the underlying JS object.   are several changes here:

Review of attachment 663060 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +2658,5 @@
> +  } while (0);
> +  if (!JS_DefineElement(cx, returnArray, i, tmp,
> +                        nullptr, nullptr, JSPROP_ENUMERATE)) {
> +    return false;
> +  }  

Trailing whitespace

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 663060 [details] [diff] [review]
Fix JS-wrapping of callback interfaces to just return the underlying JS object.   are several changes here:

Looks good, r=jst

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/rev/2803709dc340

Comment 5

[Boris Zbarsky [:bzbarsky]]

Er, I meant https://hg.mozilla.org/integration/mozilla-inbound/rev/2803709dc340

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2803709dc340