792988 - Otoro builds broken: "media/omx-plugin/OmxPlugin.cpp:605: error: 'OMX_QCOM_COLOR_FormatYVU420SemiPlanar' was not declared in this scope"

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4be1a01f58f3#l1.114 removed these local defines of constants.

This isn't tbpl builds, which is *highly* disturbing.  Does this code depend on device-specific environment?  That's something we need to fix; maybe it's what the local constants were trying to achieve.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Restore local defines of constants, because removing them breaks otoro builds (!!)

We need to get the build bustage off of inbound *ASAP*, but after that we need to make sure this kind of problem doesn't happen again.  Likely a problem with the b2g build config.

Comment 2

[Michael Wu [:mwu]]

The omx plugin isn't enabled on tbpl. It has to be explicitly turned on and the mozconfig doesn't turn it on. I also don't know if our b2g toolchain package currently supports OMX.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d8a6c8f06cc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d8a6c8f06cc