Closed
Bug 792989
Opened 13 years ago
Closed 13 years ago
update create_talos_zip.py to point to k0s vendor branch for oauth2 on python 2.4
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
Attachments
(1 file)
1.02 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
oauth2 has some serious issues on python 2.4:
https://bugzilla.mozilla.org/show_bug.cgi?id=789972
While a pull request has been submitted for these issues,
https://github.com/simplegeo/python-oauth2/pull/120 , I have no idea
when or if this will be merged. In the interim, create_talos_zip.py
should point to a vendor version: https://github.com/k0s/python-oauth2
.
Once we drop python 2.4 we can again point at simplegeo/oauth2
Reporter | ||
Comment 1•13 years ago
|
||
Oh, I'm not a fan. That said, I can't think of another solution outside of just turning off windows.
Attachment #663187 -
Flags: review?(jmaher)
Comment 2•13 years ago
|
||
Comment on attachment 663187 [details] [diff] [review]
point to a (ahem) "vendor branch"
Review of attachment 663187 [details] [diff] [review]:
-----------------------------------------------------------------
Oh man this is *awesome*.
Attachment #663187 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 3•13 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=3ff87bf433e6
I probably should add a comment about why we're doing this horrible thing. I'll endeavor to do so on landing
Comment 4•13 years ago
|
||
Try run for 3ff87bf433e6 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=3ff87bf433e6
Results (out of 67 total builds):
exception: 1
success: 64
failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-3ff87bf433e6
Reporter | ||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3333c226a1d8
https://hg.mozilla.org/integration/mozilla-inbound/rev/83f801de85fb
Assignee: nobody → anujagarwal464
Comment 7•11 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/3333c226a1d8
> https://hg.mozilla.org/integration/mozilla-inbound/rev/83f801de85fb
argh ignore, commit message was wrong
Updated•11 years ago
|
Assignee: anujagarwal464 → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•