793083 - Add more custom views to the LayoutInflater factory

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I noticed that AboutHomeContent and AboutHomeContent$TopSitesGridView were not in the GeckoViewsFactory. Since they are in the startup path, I figured it made sense to add them.

TabsPanel$TabsPanelToolbar and TabsPanel$TabsListContainer are also not in the factory, but maybe they are not in the startup path. If you want these in too, let me know.

I also made the "Error" for a unknown views be a warning instead. Unknown views are still handled by the default layout inflater factory, so it's not an error.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 663276 [details] [diff] [review]
patch

Review of attachment 663276 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I have a similar patch in another bug.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/67be22778e30

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67be22778e30