Closed Bug 793083 Opened 7 years ago Closed 7 years ago

Add more custom views to the LayoutInflater factory

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 18

People

(Reporter: mfinkle, Unassigned)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I noticed that AboutHomeContent and AboutHomeContent$TopSitesGridView were not in the GeckoViewsFactory. Since they are in the startup path, I figured it made sense to add them.

TabsPanel$TabsPanelToolbar and TabsPanel$TabsListContainer are also not in the factory, but maybe they are not in the startup path. If you want these in too, let me know.

I also made the "Error" for a unknown views be a warning instead. Unknown views are still handled by the default layout inflater factory, so it's not an error.
Attachment #663276 - Flags: review?(sriram)
Comment on attachment 663276 [details] [diff] [review]
patch

Review of attachment 663276 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I have a similar patch in another bug.
Attachment #663276 - Flags: review?(sriram) → review+
Target Milestone: --- → Firefox 18
https://hg.mozilla.org/mozilla-central/rev/67be22778e30
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.