Exactly root JSClassInitializerOp functions

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(2 attachments)

This bug will change the JSObject* parameter of JSClassInitializerOp to HandleObject.
This patch converts JSClassInitializerOp.
Attachment #663296 - Flags: review?(sphink)
This patch removes jsproto.tbl, which is dead.  It appears that
jsprototypes.h is the true source for this info.
Attachment #663297 - Flags: review?(jorendorff)
Comment on attachment 663296 [details] [diff] [review]
(part 1) - Convert JSClassInitializerOp parameter to HandleObject.

Review of attachment 663296 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we want to convert return values to RawObjects. We don't really know what we want to convert those to, if anything, but I'd rather only use RawObject for parameters and maybe local variables. We might create an UnrootedObject type for return values, but it doesn't exist yet. (It could start out as a typedef for JSObject*, but could be made into something fancy that is usable for constructing a Rooted but does not autoconvert to JSObject*, unlike Rooted and Handle.)

The other changes look good. So r=me if you revert all of the return values to JSObject*. If you want to do something else with them, then please request re-review.
Attachment #663296 - Flags: review?(sphink) → review+
Comment on attachment 663297 [details] [diff] [review]
(part 2) - Remove jsproto.tbl.

I thought I did this, and in fact I'm pretty sure I did this.  :-\  Maybe the file-removal got lost during mq rebasing or something, sigh.
Attachment #663297 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/2d0fac2bc177
https://hg.mozilla.org/mozilla-central/rev/461384440ce3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.