Last Comment Bug 793088 - Startup failure in localization builds since Aurora17.0a2 20120920042010
: Startup failure in localization builds since Aurora17.0a2 20120920042010
Product: Release Engineering
Classification: Other
Component: General Automation (show other bugs)
: other
: x86 All
: -- blocker (vote)
: ---
Assigned To: Rail Aliiev [:rail] ⌚️ET
: Chris AtLee [:catlee]
: 793101 793149 793164 793200 793207 (view as bug list)
Depends on: 772446
Blocks: 793379
  Show dependency treegraph
Reported: 2012-09-20 22:55 PDT by Alice0775 White
Modified: 2013-08-12 21:54 PDT (History)
23 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

fix v1 (1.89 KB, patch)
2012-09-21 08:28 PDT, Rail Aliiev [:rail] ⌚️ET
catlee: review+
rail: checked‑in+
Details | Diff | Splinter Review

Description Alice0775 White 2012-09-20 22:55:18 PDT
Steps to reproduce:
1. Insatall
2. Start Firefox with clean profile

Actual results:
  Startup failure

XML パースエラー: 定義されていない実体が使用されています。
URL: chrome://browser/content/browser.xul
行番号: 540, 列番号: 9:        <button default="true"

Regression Pushlog:
Comment 1 Semtex 2012-09-21 01:04:23 PDT
Similar thing happen with l10n Nightly 18a:
"XML parsing error: undefined entity
Area: chrome://browser/content/browser.xul
Line Number: 1630, column 13:
<menuitem id="appmenu_sync-tabs"

Startup failure, problem reported also here:
Comment 2 Alice0775 White 2012-09-21 02:02:41 PDT
Download from and install.
Aurora fails to start up and I get same error in comment#0

So I change mportance to blocker
Comment 3 Alice0775 White 2012-09-21 02:03:00 PDT
Comment 4 Raul Malea 2012-09-21 05:34:01 PDT
Same bug for romanian build.
Comment 5 Alexander L. Slovesnik 2012-09-21 05:45:01 PDT
Sounds like this bug affects more than one locale. CC'ing Axel.
Comment 6 Axel Hecht [:Pike] 2012-09-21 06:14:42 PDT
I don't know what's going on, the regression range in comment 0 isn't it.

Over to releng to see if there is something in the automation going wrong. Right now, the behaviour indicates is spanning locales and branches.
Comment 7 Axel Hecht [:Pike] 2012-09-21 06:40:42 PDT
So, the culprit seems to be the following:

 argv: ['make', u'installers-de', 'LOCALE_MERGEDIR=$PWD/merged']

ends up as

/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/_virtualenv/bin/python ../../config/ \
	   -j ../../dist/xpi-stage/locale-de/chrome \

that is, $PWD is expanded to WD. No idea why that'd be the case, though.

Also, verified on mac nightly german.
Comment 8 Johan C 2012-09-21 06:59:07 PDT
*** Bug 793101 has been marked as a duplicate of this bug. ***
Comment 9 Chris AtLee [:catlee] 2012-09-21 07:00:10 PDT
my guess is that this isn't being run through the shell, so $PWD isn't expanded as a bash variable. Then make sees is, and expands $P to "" and you're left with "WD".
Comment 10 Siddharth Agarwal [:sid0] (inactive) 2012-09-21 07:04:02 PDT
That should be something like ['sh', '-c', u'make installers-de LOCALE_MERGEDIR=$PWD/merged'].
Comment 11 Chris AtLee [:catlee] 2012-09-21 07:10:40 PDT
this is fallout from
Comment 12 Matthias Versen [:Matti] 2012-09-21 07:44:05 PDT
*** Bug 793164 has been marked as a duplicate of this bug. ***
Comment 13 Matthias Versen [:Matti] 2012-09-21 07:44:38 PDT
*** Bug 793149 has been marked as a duplicate of this bug. ***
Comment 14 Rail Aliiev [:rail] ⌚️ET 2012-09-21 08:28:16 PDT
Created attachment 663411 [details] [diff] [review]
fix v1
Comment 15 Rail Aliiev [:rail] ⌚️ET 2012-09-21 08:49:24 PDT
Comment on attachment 663411 [details] [diff] [review]
fix v1
Comment 16 Chris AtLee [:catlee] 2012-09-21 09:43:09 PDT
we disabled nightly and aurora updates around 07:52 PT
Comment 17 Alexander L. Slovesnik 2012-09-21 09:53:30 PDT
*** Bug 793200 has been marked as a duplicate of this bug. ***
Comment 18 Alexander L. Slovesnik 2012-09-21 09:54:56 PDT
*** Bug 793207 has been marked as a duplicate of this bug. ***
Comment 19 Raul Malea 2012-09-21 11:36:15 PDT
Error for romanian language: Eroare la analiza XML: entitate nedefinită
Adresă: chrome://browser/content/browser.xul
Număr linie 246, coloană 5:    <broadcaster id="devtoolsMenuBroadcaster_DevToolbar"
Comment 20 Rail Aliiev [:rail] ⌚️ET 2012-09-21 11:49:31 PDT
The patch worked, need to trigger a nightly build (will do in a bit).
Comment 21 Rail Aliiev [:rail] ⌚️ET 2012-09-22 04:08:13 PDT
Could somebody download and verify if the nightlies are ok?
Comment 22 Alexander L. Slovesnik 2012-09-22 05:57:07 PDT
(In reply to Rail Aliiev [:rail] from comment #21)
> Could somebody download and verify if the nightlies are ok? works for me.
Russian Windows build for central still shows the error. Apparently it's been build before patch has been checked in and not respinned.
Comment 23 Axel Hecht [:Pike] 2012-09-22 06:13:02 PDT
The l10n nightlies are still not all done yet, and windows seems to be even waiting on the en-US nightly to finish still.
Comment 24 Semtex 2012-09-22 11:00:54 PDT
(In reply to Rail Aliiev [:rail] from comment #21)
> Could somebody download and verify if the nightlies are ok?

Polish Nightly 18, working again without problem.
Comment 25 Raul Malea 2012-09-22 11:12:17 PDT
Now, romanian build win32 for Nightly working. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922030540 . Built from
Comment 26 Jake 2012-09-22 11:16:18 PDT
Shouldn't this bug affect all localization builds? Im very curious why some languages were totally fine. Like zh-CN and zh-TW are basically the same language, but ont was broken, one was ok.
Comment 27 Axel Hecht [:Pike] 2012-09-22 11:59:55 PDT
This bug affected code paths with strings missing in existing files. Depending on which strings would miss, this could break on start-up, or at some point, or, not at all, for totally complete or just as well for totally incomplete localizations.
Comment 28 Jake 2012-09-22 12:22:58 PDT
Thanks for the explanation, good to know.
Comment 29 Mad Goldfish 2012-09-23 04:14:03 PDT
Latest en-GB nightly fixed it for me.
Comment 30 Axel Hecht [:Pike] 2012-09-23 05:32:14 PDT
Marking FIXED per reports here, and inspection of some of the build logs. Let's use bug 793379 to track the updates.
Comment 31 Alex Keybl [:akeybl] 2012-09-24 16:25:18 PDT
(In reply to Rail Aliiev [:rail] from comment #15)
> Comment on attachment 663411 [details] [diff] [review]
> fix v1

Marking FF17 as fixed, please correct if wrong.
Comment 32 Mad Goldfish 2012-09-25 01:59:24 PDT
Does not work in Aurora 17.0a2, Fixed in Nightly 18.0a1
Comment 33 Justin Wood (:Callek) 2012-09-25 02:02:39 PDT
(In reply to Mad Goldfish from comment #32)
> Does not work in Aurora 17.0a2, Fixed in Nightly 18.0a1

Please give much more specific information, which aurora build did you have, which is the broken one, how did you update, and what do you mean by "does not work". Thanks
Comment 34 Mad Goldfish 2012-09-25 02:20:56 PDT
Bug, as originally reported, exists in FF17.0a2 (Aurora) - which is the current download on the website, and FF will only display the English version of XML parse error shown in the description.

FF18.0a1 (Nightly) from 2012-09-25 starts up normally as expected, and does not show the issue.

Both on Windows 7 using en-GB locale
Comment 35 Axel Hecht [:Pike] 2012-09-25 06:02:13 PDT
20120924042009 en-GB on aurora, win 7 works for me.

Note You need to log in before you can comment on or make changes to this bug.