793162 - Installation prompt not themed

Status: VERIFIED FIXED

Description

[Aaron Train [:aaronmt]]

Created attachment 663378 [details]
Nightly (09/21) - Screenshot

Minor nit bug, see screenshot. I'm on Jellybean, and it looks to be themed non-holo for Gingerbread.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This should not be limited to the App Install dialog. If this is not right, it's not right for all dialogs.

Comment 2

[Aaron Train [:aaronmt]]

Created attachment 663404 [details]
Nightly (09/21) - Screenshot (2)

Add-On prompt seems good

Comment 3

[Wesley Johnston (:wesj)]

Ahh. I know what this is. I'm using a different theme than Fennec for webapps to override the normal startup animation. There's a different way to fix that that I'll try.

Comment 4

[Wesley Johnston (:wesj)]

Created attachment 663596 [details] [diff] [review]
Patch

I think maybe we're better just not trying to do this. This will cause us to see the black box transition in quickly, then switch to the gradient fairly quickly after. It looks good to me, but happy to get some feedback.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab3709368125

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ab3709368125