Closed
Bug 793187
Opened 9 years ago
Closed 9 years ago
MMI Codes: Support PIN/PIN2/PUK handling via MMI codes
Categories
(Core :: DOM: Device Interfaces, defect, P1)
Core
DOM: Device Interfaces
Tracking
()
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [LOE:S])
Attachments
(2 files, 1 obsolete file)
5.28 KB,
patch
|
marshall
:
review+
|
Details | Diff | Splinter Review |
4.30 KB,
patch
|
marshall
:
review+
|
Details | Diff | Splinter Review |
As per device certification requirements, we need to support MMI codes for entering, changing and unlocking of PIN and PIN2 codes.
Assignee | ||
Updated•9 years ago
|
Summary: MMI Codes: Support SIM/USIM handling MMI codes → MMI Codes: Support PIN/PIN2/PUK handling via MMI codes
Assignee | ||
Updated•9 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ferjmoreno
Comment 1•9 years ago
|
||
Is this a P1 blockers or is it a nice-to-have?
Whiteboard: [blocked-on-input philikon]
Comment 2•9 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #1) > Is this a P1 blockers or is it a nice-to-have? Blocker because device certification requirement.
Whiteboard: [blocked-on-input philikon]
Updated•9 years ago
|
blocking-basecamp: ? → +
Assignee | ||
Updated•9 years ago
|
Whiteboard: [LOE:S]
Assignee | ||
Comment 3•9 years ago
|
||
I consider this task as LOE:S once bug 793186 lands
Depends on: 793186
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #669884 -
Flags: review?(marshall)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #669885 -
Flags: review?(marshall)
Assignee | ||
Comment 6•9 years ago
|
||
Now without trailing whitespaces.
Attachment #669884 -
Attachment is obsolete: true
Attachment #669884 -
Flags: review?(marshall)
Attachment #669886 -
Flags: review?(marshall)
Updated•9 years ago
|
Priority: -- → P1
Comment 7•9 years ago
|
||
Comment on attachment 669886 [details] [diff] [review] Part 1: RIL Review of attachment 669886 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just two minor nits :) ::: dom/system/gonk/ril_worker.js @@ +2327,5 @@ > options.errorMsg = errorMsg; > this.sendDOMMessage(options); > }).bind(this); > > + let _isValidICCRequest = function _isValidICCRequest() { nit: does this need to be declared as a variable? (just using a named function should suffice, unless you meant to bind it?) also, this function name seems overly broad if you're only validating registration MMI procedures..
Attachment #669886 -
Flags: review?(marshall) → review+
Comment 8•9 years ago
|
||
Comment on attachment 669885 [details] [diff] [review] Part 2: Tests Review of attachment 669885 [details] [diff] [review]: ----------------------------------------------------------------- \o/ for tests. Can you also add test case(s) for the new PINs being different (NEW_PIN_MISMATCH)? r=me with that
Attachment #669885 -
Flags: review?(marshall) → review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8eb7dfe8678 https://hg.mozilla.org/integration/mozilla-inbound/rev/4807f1c1308e
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c8eb7dfe8678 https://hg.mozilla.org/mozilla-central/rev/4807f1c1308e
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/557a3f5164e6 https://hg.mozilla.org/releases/mozilla-aurora/rev/3a82fae11d50
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Updated•8 years ago
|
Blocks: b2g-v1-certification
You need to log in
before you can comment on or make changes to this bug.
Description
•