Closed Bug 793267 Opened 7 years ago Closed 7 years ago

Implement [Unforgeable] in WebIDL bindings

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 4 obsolete files)

No description provided.
prototype.  So we keep them in a separate spec array and define them
during object creation as needed.

This means that we have to pass that separate spec array to the Xray
helpers, unfortunately, which somewhat complicates those.
Attachment #663639 - Flags: review?(peterv)
Whiteboard: [need review]
Actually, that doesn't necessarily work right for proxy bindings...  I should add something to make those fail codegen.
Attached patch With that fixed (obsolete) — Splinter Review
Attachment #663641 - Flags: review?(peterv)
Attachment #663639 - Attachment is obsolete: true
Attachment #663639 - Flags: review?(peterv)
Attached patch And updated diff -w (obsolete) — Splinter Review
Attachment #663640 - Attachment is obsolete: true
No longer blocks: 795343
Attached patch Merged to tipSplinter Review
Attachment #671599 - Flags: review?(peterv)
Attachment #663641 - Attachment is obsolete: true
Attachment #663641 - Flags: review?(peterv)
Attachment #663642 - Attachment is obsolete: true
Comment on attachment 671599 [details] [diff] [review]
Merged to tip

Review of attachment 671599 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +1529,5 @@
> +    """
> +    properties is a PropertyArrays instance
> +    """
> +    defineUnforgeables = ("if (!DefineUnforgeableAttributes(aCx, obj, %s)) {\n"
> +                          "  return NULL;\n"

nullptr
Attachment #671599 - Flags: review?(peterv) → review+
Depends on: 778152
http://hg.mozilla.org/integration/mozilla-inbound/rev/b02152aa3ed8
No longer depends on: 778152
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/b02152aa3ed8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.