793267 - Implement [Unforgeable] in WebIDL bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add support for [Unforgeable] in WebIDL. attributes are defined directly on the object, not on the

prototype.  So we keep them in a separate spec array and define them
during object creation as needed.

This means that we have to pass that separate spec array to the Xray
helpers, unfortunately, which somewhat complicates those.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Diff -w, might be easier to review in places

Comment 3

[Boris Zbarsky [:bzbarsky]]

Actually, that doesn't necessarily work right for proxy bindings...  I should add something to make those fail codegen.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: With that fixed

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: And updated diff -w

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Merged to tip

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: And the diff -w

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 671599 [details] [diff] [review]
Merged to tip

Review of attachment 671599 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +1529,5 @@
> +    """
> +    properties is a PropertyArrays instance
> +    """
> +    defineUnforgeables = ("if (!DefineUnforgeableAttributes(aCx, obj, %s)) {\n"
> +                          "  return NULL;\n"

nullptr

Comment 9

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b02152aa3ed8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b02152aa3ed8