new android updater downloads on cell data connection without asking

VERIFIED FIXED in Firefox 17

Status

()

Firefox for Android
General
--
blocker
VERIFIED FIXED
5 years ago
11 months ago

People

(Reporter: cdlrobinson, Assigned: snorp)

Tracking

({dogfood})

Trunk
Firefox 18
ARM
Android
dogfood
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox17+ fixed, firefox18+ verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

I dismissed the notification that a download was available since I was not on WiFi and have a limited data plan.


Actual results:

later when I checked my phone there was a notification to install the downloaded update.


Expected results:

The download should not happen over a cell data connection unless I select to download it. 

I would prefer a setting to not even offer the download unless the phone is on WiFi.

Updated

5 years ago
Assignee: nobody → snorp
Blocks: 786380
OS: Windows XP → Android
Hardware: x86 → ARM
See Also: → bug 774432

Updated

5 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

5 years ago
Since there's apparently no way to disable the new update service, I had to uninstall Nightly :-(
Severity: normal → blocker
Keywords: dogfood

Updated

5 years ago
tracking-firefox17: --- → ?
tracking-firefox18: --- → ?
Had this happen to me this morning too as soon as I turned my device on and switched to cellular, the download initiated.

Comment 3

5 years ago
Tracking for release, but we'll untrack for versions as the move to beta (which doesn't use the updater).
tracking-firefox17: ? → +
tracking-firefox18: ? → +

Updated

5 years ago
Duplicate of this bug: 795705
From bug 795705: "I have 300 MB monthly data limit. Right now, in the "middle" of the month I used 220 MB out of 300, and Firefox used 136 MB alone, that is more than all other apps combined."
Created attachment 666547 [details] [diff] [review]
Make sure we do not force an automatic download for Android updates
Attachment #666547 - Flags: review?(mark.finkle)
The "force download" flag that we include in the intent that is used when you accept an update over mobile data was accidentally kept later on when we did a scheduled update check. Attached patch fixes that. Stupid API.
Comment on attachment 666547 [details] [diff] [review]
Make sure we do not force an automatic download for Android updates

Yeah, not the most straight forward API
Attachment #666547 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c035b44ef28
https://hg.mozilla.org/mozilla-central/rev/8c035b44ef28

Should this have a test?
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox18: --- → fixed
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
(In reply to Ryan VanderMeulen from comment #10)
> https://hg.mozilla.org/mozilla-central/rev/8c035b44ef28
> 
> Should this have a test?

No way currently to have an automated test for this, no.

You should be able to reproduce the bug prior to this fix, though, with the following STR:

1) Disable wifi, ensure you have a mobile data connection
2) Go to about:firefox, click 'check for updates' (with an old enough nightly obviously)
3) When prompted, start the update download
4) Swipe to cancel the 'apply update' notification, or cancel the installation after clicking on the notification.
5) Check for updates again, and the download would start automatically.
Updates are not downloaded automatically on 3G on the latest Nightly. Each time when STR from comment #11 are performed, the update notification is triggered which it's expected.
Closing bug as verified fixed on:

Firefox 18.0a1 (2012-10-08)
Device: Galaxy Nexus
OS: Android 4.1.1
Status: RESOLVED → VERIFIED
status-firefox18: fixed → verified

Updated

5 years ago
status-firefox17: --- → affected
Looks like we still need a beta uplift nom here if we want this to go out with 17.
Comment on attachment 666547 [details] [diff] [review]
Make sure we do not force an automatic download for Android updates

[Approval Request Comment]
Low-risk, fixes annoying user-facing update bug
Attachment #666547 - Flags: approval-mozilla-beta?
Comment on attachment 666547 [details] [diff] [review]
Make sure we do not force an automatic download for Android updates

Definitely worth uplifting this fix to reduce an annoying user-facing issue.
Attachment #666547 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/518ee633eb9c

Updated

5 years ago
status-firefox17: affected → fixed
Depends on: 808595
You need to log in before you can comment on or make changes to this bug.