793308 - Remove "string.h" includes from /content/svg

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

In reviewing bug 567848, I noticed some [#include "string.h" / #include <string.h>] statements that are unused/unnecessary.  (I can still build just fine if I remove them.)

In particular, these files have string.h includes that can be removed:
content/svg/content/src/SVGLengthList.cpp
content/svg/content/src/SVGNumberList.cpp
content/svg/content/src/SVGPathData.cpp
content/svg/content/src/SVGPathData.h
content/svg/content/src/SVGPointList.cpp
content/svg/content/src/SVGPointList.h

(This touches the same code as bug 567848, so I'm not posting a patch yet since it'd either bitrot bug 567848 or be bitrotted by bug 567848.  Trivial fix once bug 567848 lands, though.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Actually, SVGPathData.h and SVGPointList.h presumably have the #include because they use memcmp() in some inline code.  We still build with the attached patch, presumably because we're getting <string.h> from elsewhere, but we shouldn't rely on that.

The rest of the files from comment 0 don't use memcmp() or memset(), though, and I don't think they use any other string.h functions, so I think they still want to drop string.h.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

(reverted changes to two files, per prev comment)

Comment 4

[Daniel Holbert [:dholbert]]

FWIW, I verified (w/ grep) that the touched files don't make any calls to mem*() or str*() (I believe all string.h-exported methods fall into one of those naming schemes)

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/280c4fb7794d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/280c4fb7794d

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/280c4fb7794d