793311 - crash in nsDOMFileFile::nsDOMFileFile

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

This bug was filed from the Socorro interface and is 
report bp-9c68a646-ff9a-4a20-ba82-d7d792120921 .
============================================================= 
0 	xul.dll 	nsDOMFileFile::nsDOMFileFile 	obj-firefox/dist/include/nsDOMFile.h:192
1 	xul.dll 	nsDOMWindowUtils::WrapDOMFile 	dom/base/nsDOMWindowUtils.cpp:2302
2 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70
3 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2405
4 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1469
5 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
6 	mozjs.dll 	js::Invoke 	js/src/jsinterp.h:109
7 	mozjs.dll 	js_fun_apply 	js/src/jsfun.cpp:951
8 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
9 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2454
10 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:378
etc...


Happens with SpecialPowers.DOMWindowUtils.wrapDOMFile(null)

Str:
- Install http://people.mozilla.org/~mwargers/extensions/specialpowers/specialpowers.xpi
- Load testcase

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

DOMWindowUtils.wrapDOMFile doesn't handle null; should it?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'll r+ a null check, but this isn't a priority.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: patch 1

Comment 4

[Andrea Marchesini [:baku]]

Attachment: patch + test

mochitest added

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I don't see any Try results posted, so I've pushed this to be safe. I'll land it if the push is green.
https://tbpl.mozilla.org/?tree=Try&rev=7c6f0e0bae23

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen from comment #5)
> https://tbpl.mozilla.org/?tree=Try&rev=7c6f0e0bae23

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/768c8c6d3fe0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/768c8c6d3fe0