Closed Bug 793311 Opened 7 years ago Closed 7 years ago

crash in nsDOMFileFile::nsDOMFileFile

Categories

(Core :: DOM: Core & HTML, defect, critical)

x86
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: martijn.martijn, Assigned: baku)

Details

(Keywords: crash, testcase, Whiteboard: [mentor=khuey][lang=c++])

Crash Data

Attachments

(2 files, 1 obsolete file)

Attached file testcase
This bug was filed from the Socorro interface and is 
report bp-9c68a646-ff9a-4a20-ba82-d7d792120921 .
============================================================= 
0 	xul.dll 	nsDOMFileFile::nsDOMFileFile 	obj-firefox/dist/include/nsDOMFile.h:192
1 	xul.dll 	nsDOMWindowUtils::WrapDOMFile 	dom/base/nsDOMWindowUtils.cpp:2302
2 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70
3 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2405
4 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1469
5 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
6 	mozjs.dll 	js::Invoke 	js/src/jsinterp.h:109
7 	mozjs.dll 	js_fun_apply 	js/src/jsfun.cpp:951
8 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
9 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2454
10 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:378
etc...


Happens with SpecialPowers.DOMWindowUtils.wrapDOMFile(null)

Str:
- Install http://people.mozilla.org/~mwargers/extensions/specialpowers/specialpowers.xpi
- Load testcase
DOMWindowUtils.wrapDOMFile doesn't handle null; should it?
Keywords: testcase
OS: Windows NT → Windows 7
Version: unspecified → Trunk
I'll r+ a null check, but this isn't a priority.
Whiteboard: [mentor=khuey][lang=c++]
Attached patch patch 1 (obsolete) — Splinter Review
Attachment #664072 - Flags: review?(khuey)
Keywords: checkin-needed
Attached patch patch + testSplinter Review
mochitest added
Attachment #664072 - Attachment is obsolete: true
Attachment #664097 - Flags: review+
I don't see any Try results posted, so I've pushed this to be safe. I'll land it if the push is green.
https://tbpl.mozilla.org/?tree=Try&rev=7c6f0e0bae23
(In reply to Ryan VanderMeulen from comment #5)
> https://tbpl.mozilla.org/?tree=Try&rev=7c6f0e0bae23

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/768c8c6d3fe0
Assignee: nobody → amarchesini
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/768c8c6d3fe0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.