crash in nsDOMFileFile::nsDOMFileFile

RESOLVED FIXED in mozilla18

Status

()

Core
DOM
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: baku)

Tracking

({crash, testcase})

Trunk
mozilla18
x86
Windows 7
crash, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=khuey][lang=c++], crash signature)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 663554 [details]
testcase

This bug was filed from the Socorro interface and is 
report bp-9c68a646-ff9a-4a20-ba82-d7d792120921 .
============================================================= 
0 	xul.dll 	nsDOMFileFile::nsDOMFileFile 	obj-firefox/dist/include/nsDOMFile.h:192
1 	xul.dll 	nsDOMWindowUtils::WrapDOMFile 	dom/base/nsDOMWindowUtils.cpp:2302
2 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70
3 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2405
4 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1469
5 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
6 	mozjs.dll 	js::Invoke 	js/src/jsinterp.h:109
7 	mozjs.dll 	js_fun_apply 	js/src/jsfun.cpp:951
8 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
9 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2454
10 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:378
etc...


Happens with SpecialPowers.DOMWindowUtils.wrapDOMFile(null)

Str:
- Install http://people.mozilla.org/~mwargers/extensions/specialpowers/specialpowers.xpi
- Load testcase
DOMWindowUtils.wrapDOMFile doesn't handle null; should it?

Updated

6 years ago
Keywords: testcase
OS: Windows NT → Windows 7
Version: unspecified → Trunk
I'll r+ a null check, but this isn't a priority.
Whiteboard: [mentor=khuey][lang=c++]
(Assignee)

Comment 3

6 years ago
Created attachment 664072 [details] [diff] [review]
patch 1
Attachment #664072 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

6 years ago
Created attachment 664097 [details] [diff] [review]
patch + test

mochitest added
Attachment #664072 - Attachment is obsolete: true
Attachment #664097 - Flags: review+
I don't see any Try results posted, so I've pushed this to be safe. I'll land it if the push is green.
https://tbpl.mozilla.org/?tree=Try&rev=7c6f0e0bae23
(In reply to Ryan VanderMeulen from comment #5)
> https://tbpl.mozilla.org/?tree=Try&rev=7c6f0e0bae23

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/768c8c6d3fe0
Assignee: nobody → amarchesini
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/768c8c6d3fe0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.