793420 - Remove the waiting timer for the 'open-app' mozChromeEvents requested by System Message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Bug 793082 introduced a generalized mozChromeEvent sender in place that will wait for System app to load. We can go ahead and remove timer introduced in bug 783149.

This can basically done by doing |patch -p1 -R| on attachment 656728 [details] [diff] [review]. However we need to verify we don't break anything. Gene, Ian, what's the STR to test that?

Comment 1

[Gene Lian (I already quit Mozilla)]

Yes. We need to carefully have a test on that. The original need for such a timer is to solve the Alarm API issues. The STR is listed as below:

1. Set an Alarm clock time.
2. Shutdown the device and wait until we "passed" the time we set at #1.
3. Turn on the device.
4. If everything works, the expired alarm should be fired when booting up.

Comment 2

[Andrew Overholt [:overholt]]

It seems like this was created with blocking-basecamp+ (by using clone bug on a blocker?) but we discussed it during triage and decided it wasn't actually a blocker.  Feel free to re-nom if you disagree.

Comment 3

[Gene Lian (I already quit Mozilla)]

Hi Tim,

If you don't mind I can help verify this to see if we can really remove the timer, since Bug 793082 has been done.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Gene Lian [:gene] from comment #3)
> Hi Tim,
> 
> If you don't mind I can help verify this to see if we can really remove the
> timer, since Bug 793082 has been done.

Please do, thank you!

Comment 5

[Gene Lian (I already quit Mozilla)]

This bug is related to bug 1013671. If we can use SystemAppProxy to fire "system-messages-open-app", we might rely on the SystemAppProxy.setIsReady() to pend the chrome events until the system completely boots up, so that we can remove the ugly 10-sec timer here.

This might be another interesting bug for newbies.

Comment 6

[Sean Lin [:seanlin] (inactive from Mar 2016)]

The code fix for this bug is combined with the patch of bug 1013671. Abd it has passed review and is waiting for checking in.

Comment 7

[Sean Lin [:seanlin] (inactive from Mar 2016)]

The patch of bug 1013671, including the fix for this bug, has landed. Resolving.