Closed Bug 793440 Opened 7 years ago Closed 7 years ago

Tautological constant out of range check on DOMSVGTransform.h

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: reuben, Assigned: reuben)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
This breaks the build on a recent Clang.
Attachment #663741 - Flags: review?(jwatt)
This is right but it's not enough, it shows we have other issues.

mIsAnimValItem should be  

uint32_tmIsAnimValItem:1; 

in DOMSVGTransform.h

also MOZ_SVG_LIST_INDEX_BIT_COUNT should be 31 (the data items should add to 32) in that class. So it looks to me like DOMSVGNumber.h and DOMSVGLength.h have correct values.

Then DOMSVGNumber.h and DOMSVGLength.h should take bool arguments for aIsAnimValItem so that we can remove the aIsAnimValItem < (1 << 1) check from DOMSVGLength.cpp and DOMSVGNumber.cpp too.

If you don't want to do all that, please raise a follow up so that we can track it.
make that

uint32_t mIsAnimValItem:1;
Attached patch PatchSplinter Review
Sure :)
Attachment #663741 - Attachment is obsolete: true
Attachment #663741 - Flags: review?(jwatt)
Attachment #663753 - Flags: review?(longsonr)
Comment on attachment 663753 [details] [diff] [review]
Patch

Thanks Reuben.
Attachment #663753 - Flags: review?(longsonr) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0fbabfc42867
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.