793440 - Tautological constant out of range check on DOMSVGTransform.h

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Patch

This breaks the build on a recent Clang.

Comment 1

[Robert Longson [:longsonr]]

This is right but it's not enough, it shows we have other issues.

mIsAnimValItem should be  

uint32_tmIsAnimValItem:1; 

in DOMSVGTransform.h

also MOZ_SVG_LIST_INDEX_BIT_COUNT should be 31 (the data items should add to 32) in that class. So it looks to me like DOMSVGNumber.h and DOMSVGLength.h have correct values.

Then DOMSVGNumber.h and DOMSVGLength.h should take bool arguments for aIsAnimValItem so that we can remove the aIsAnimValItem < (1 << 1) check from DOMSVGLength.cpp and DOMSVGNumber.cpp too.

If you don't want to do all that, please raise a follow up so that we can track it.

Comment 2

[Robert Longson [:longsonr]]

make that

uint32_t mIsAnimValItem:1;

Comment 3

[Reuben Morais [:reuben]]

Attachment: Patch

Sure :)

Comment 4

[Robert Longson [:longsonr]]

Comment on attachment 663753 [details] [diff] [review]
Patch

Thanks Reuben.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=e8bb654fd567

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fbabfc42867

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0fbabfc42867