793461 - Uninstalling metro browser should remove the whole appusermodelid reg keys

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Brian R. Bondy [:bbondy]]

Only the metro browser sets these keys as far as I can tell:
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\EEFEA8717BC47F65
HKEY_CURRENT_USER\SOFTWARE\Classes\EEFEA8717BC47F65

This causes problems if you install a metro browser to some location, then uninstall, then install an on metro browser.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Comment 2

[Brian R. Bondy [:bbondy]]

The problems that it creates when you uninstall a metro browser, and install a non metro browser are only on win8 by the way, and if you click on the taskbar icon to launch the browser, it opens firefox but also tries to download firefox.exe.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2

Just realized that I was removing that key conditionally on if we were the deafault browser. But it should always be removed.

Comment 4

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/projects/elm/rev/e7d3252d18e4
http://hg.mozilla.org/projects/elm/rev/a035f299cb23
Will sync review comments to elm

Comment 5

[Brian R. Bondy [:bbondy]]

These bits are already on m-c. It doesn't matter since it's behind a MOZ_METRO ifdef, but we should keep the bits in sync.  So the review is for m-c.

Comment 6

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/955415a397bf

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/955415a397bf