Closed Bug 793461 Opened 8 years ago Closed 8 years ago

Uninstalling metro browser should remove the whole appusermodelid reg keys

Categories

(Firefox :: Installer, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 18

People

(Reporter: bbondy, Assigned: bbondy)

Details

(Whiteboard: metro-preview completed-elm)

Attachments

(1 file, 1 obsolete file)

Only the metro browser sets these keys as far as I can tell:
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\EEFEA8717BC47F65
HKEY_CURRENT_USER\SOFTWARE\Classes\EEFEA8717BC47F65

This causes problems if you install a metro browser to some location, then uninstall, then install an on metro browser.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #663783 - Flags: review?(jmathies)
The problems that it creates when you uninstall a metro browser, and install a non metro browser are only on win8 by the way, and if you click on the taskbar icon to launch the browser, it opens firefox but also tries to download firefox.exe.
Attached patch Patch v2Splinter Review
Just realized that I was removing that key conditionally on if we were the deafault browser. But it should always be removed.
Attachment #663783 - Attachment is obsolete: true
Attachment #663783 - Flags: review?(jmathies)
Attachment #663784 - Flags: review?(jmathies)
http://hg.mozilla.org/projects/elm/rev/e7d3252d18e4
http://hg.mozilla.org/projects/elm/rev/a035f299cb23
Will sync review comments to elm
Whiteboard: metro-preview completed-elm
These bits are already on m-c. It doesn't matter since it's behind a MOZ_METRO ifdef, but we should keep the bits in sync.  So the review is for m-c.
Attachment #663784 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/955415a397bf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.