Closed Bug 793479 Opened 8 years ago Closed 8 years ago
Process Has Permission to Assert App Process Permission
AppProcessHasPermission() does more than just a check and return a bool: it kills the content process if it doesn't have the permission that's being queried. The naming should reflect that. In bug 776832 we went with "assertPermission", so I'm proposing AssertAppProcessPermission().
Assignee: philipp → jones.chris.g
Attachment #663796 - Flags: review?(justin.lebar+bug)
Comment on attachment 663796 [details] [diff] [review] Update C++ permission-checking API to match that of the message-manager one > /** > * Return true iff any of the PBrowsers loaded in this content process > * has the specified capability. > */ Can you update the comment here, too? (It's not clear to me that the comment above applies here, since this one also has an explicit comment.) > bool >-AppProcessHasPermission(mozilla::dom::PContentParent* aActor, >- const char* aPermission); >+AssertAppProcessPermission(mozilla::dom::PContentParent* aActor, >+ const char* aPermission);
Attachment #663796 - Flags: review?(justin.lebar+bug) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.