793498 - nsMediaSniffer.cpp:21:2125: warning: deleting object of polymorphic class type ‘nsMediaSniffer’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning with GCC 4.7:
{
toolkit/components/mediasniffer/nsMediaSniffer.cpp: In member function ‘virtual nsrefcnt nsMediaSniffer::Release()’:
toolkit/components/mediasniffer/nsMediaSniffer.cpp:21:2125: warning: deleting object of polymorphic class type ‘nsMediaSniffer’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
}

Elsewhere, we've fixed this by adding the MOZ_FINAL label, and I think that's what we want here, too.  Nothing derives from nsMediaSniffer at the moment, so the label is an appropriate one.

Depends on:   567077

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

I verified that this compiles & fixes the build warning on my machine.

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 663818 [details] [diff] [review]
fix

Review of attachment 663818 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f52262d00c06

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f52262d00c06