793548 - Valgrind on tbpl detects leak at malloc (72 bytes in 1 blocks are definitely lost) with CrashReporter::SetupExtraData on the stack

Status: RESOLVED WORKSFORME

(Toolkit :: Crash Reporting, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Valgrind stack

Valgrind detects a leak of 72 bytes at malloc with CrashReporter::SetupExtraData on the stack, see attached snippet which comes from:

https://tbpl.mozilla.org/php/getParsedLog.php?id=15458553&tree=Firefox&full=1

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Guessing Core:XPCOM, please change component if necessary.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: m-c changeset 555f91476597 Valgrind stack with line numbers

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Suppression updated in https://hg.mozilla.org/mozilla-central/rev/766f39da353b

Comment 4

[Nicholas Nethercote [inactive]]

This is another one where we deliberately leak due to the use of PR_SetEnv().  The suppression (already present) is the right way to handle it.