793549 - Valgrind on tbpl detects leak at realloc (145 bytes in 1 blocks are definitely lost) with GrowStuff on the stack

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Valgrind stack

Valgrind detects a leak of 145 bytes at realloc with GrowStuff on the stack, see attached snippet which comes from:

https://tbpl.mozilla.org/php/getParsedLog.php?id=15458553&tree=Firefox&full=1

Guessing Core:XPCOM component, please change if necessary.

Comment 1

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/file/e327e66a027d/toolkit/xre/nsAppRunner.cpp#l257

Comment 2

[Jesse Ruderman]

Is there a (valgrind.h) annotation for "I expect this to leak"?  Or should we just add this to the Valgrind suppression file?

Comment 3

[Julian Seward [:jseward]]

No, there's no such annotation.  You just have to suppress it in the normal way.

Comment 4

[Jesse Ruderman]

Or maybe Valgrind should intercept setenv?

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: m-c changeset 555f91476597 Valgrind stack with line numbers