Closed Bug 793585 Opened 13 years ago Closed 13 years ago

Intermittent test_bug733553.html | Test timed out

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox17 --- unaffected
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: philor, Assigned: unusualtears)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Only default the shared state if it's not there.
2.02 KB, patch
joe
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=15472188&tree=Mozilla-Inbound Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitests-4/5 on 2012-09-23 22:36:18 PDT for push 1c2e9acb91a3 slave: talos-r4-snow-053 15225 INFO TEST-START | /tests/image/test/mochitest/test_bug733553.html 15226 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test timed out. (screenshot) 15227 INFO TEST-END | /tests/image/test/mochitest/test_bug733553.html | finished in 326571ms
https://tbpl.mozilla.org/php/getParsedLog.php?id=15472885&tree=Mozilla-Inbound The fact that that's two in a row would worry me, except that it started on a push that touched accessible/tests/mochitest/events/test_docload.xul, and I don't think we run ally tests except in mochitest-a11y, part of mochitest-other except not on OS X.
Blocks: 787899
Adam, you fixed the last such bug, and somehow I reintroduced it. Any ideas here? I'm stumped.
I was able to get it to reproduce on Try with some minor debugging included (the full log shows a little more): https://tbpl.mozilla.org/php/getParsedLog.php?id=15828600&tree=Try From the full log: > set part to 0 > did setSharedState to 0 > got nextPart as -1 > [...] > got nextPart as -1 > 15200 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test timed out. So the "informant" sjs sets the right part, but the "image" sjs doesn't pick up the shared state. Not sure why yet. Also noteworthy is that the sjs keeps running (the line "got nextPart as -1" is repeated throughout the rest of the log, long after this test ends).
Assignee: nobody → unusualtears
Status: NEW → ASSIGNED
(In reply to Adam [:hobophobe] from comment #36) > Also noteworthy is that the sjs keeps running (the line "got nextPart as -1" > is repeated throughout the rest of the log, long after this test ends). Yeah, that will happen because we set a timer to check whether the nextPart is set every second.
https://tbpl.mozilla.org/php/getParsedLog.php?id=15882930&tree=Try holds the answer, with the full log showing the problem: > set part to 0 > _setSharedState for next-part to 0 > did setSharedState to 0 > _setSharedState for next-part to -1 > _getSharedState for next-part as -1 > got nextPart as -1 Line four is done by bug733553.sjs:46, which is supposed to set the default value. Here's the same portion from a successful attempt: > set part to 0 > _setSharedState for next-part to -1 > _getSharedState for next-part as -1 > got nextPart as -1 > _setSharedState for next-part to 0 > did setSharedState to 0 > _getSharedState for next-part as 0 > got nextPart as 0 So, that line in bug733553.sjs can happen after it's set by bug733553-informant.sjs, which doesn't get another turn. Fix is to only set the default if the shared state is not already there. I also changed test_bug733553.html to always call |readyForNext| in |imageLoad| so that it'll get called one extra time at the end, which will correctly get bug733553.sjs to |sendClose| and stop repeating indefinitely. That will only happen for successful runs, but there's no |registerCleanupFunction| for mochitest-plain, so I think that's as good as it gets. Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=d518d6d803ab
Attachment #669294 - Flags: review?(joe)
Comment on attachment 669294 [details] [diff] [review] Only default the shared state if it's not there. Review of attachment 669294 [details] [diff] [review]: ----------------------------------------------------------------- yessss. you rock.
Attachment #669294 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/4a6c1725dd4b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: