implement mask-type property from CSS Masking

RESOLVED FIXED in mozilla20

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
8 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla20
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 663963 [details] [diff] [review]
WIP (v0.1)

The initially proposed maskType="" attribute on <mask> morphed into a mask-type property that applies to <mask> elements last week during the SVG WG's F2F.  A WebKit implementation landed later that week (perhaps a record time between spec change and implementation appearing?): http://trac.webkit.org/changeset/129018

Attached is a WIP implementation.

David, can you give some guidance on what we should be doing here with prefixes?
Attachment #663963 - Flags: feedback?(dbaron)
Comment on attachment 663963 [details] [diff] [review]
WIP (v0.1)

I think we should not prefix.  If WebKit-based browsers are shipping this, then it's fine for us to ship it too; if not, we probably want to put it behind a pref if the spec isn't stable yet.
Attachment #663963 - Flags: feedback?(dbaron) → feedback+
And you need to add to property_database.js and then make sure the layout/style mochitests pass.
(Assignee)

Comment 3

5 years ago
Created attachment 678965 [details] [diff] [review]
patch

r?longsonr for {content,layout}/svg/ changes, r?dbaron for the rest.  I've used layout.css.masking.enabled as the pref to put this behind, with the expectation that other things we implement from the CSS Masking specification go behind that pref too.
Attachment #663963 - Attachment is obsolete: true
Attachment #678965 - Flags: review?(longsonr)
Attachment #678965 - Flags: review?(dbaron)

Comment 4

5 years ago
Comment on attachment 678965 [details] [diff] [review]
patch

I'd like to see a SMIL animation reftest too.
Attachment #678965 - Flags: review?(longsonr) → review+
Comment on attachment 678965 [details] [diff] [review]
patch

r=dbaron on the parts requested
Attachment #678965 - Flags: review?(dbaron) → review+

Updated

5 years ago
Keywords: dev-doc-needed

Comment 6

5 years ago
Is there any reason not to land this?
(Assignee)

Comment 7

5 years ago
We just this morning had a telcon where we resolved some concerns about the naming of this property.  So I will be landing it today.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e043d5feb0b6
https://hg.mozilla.org/mozilla-central/rev/e043d5feb0b6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Documentation done:
https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type (with live sample)
and
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/20
Keywords: dev-doc-needed → dev-doc-complete

Updated

8 months ago
Blocks: 1312613
You need to log in before you can comment on or make changes to this bug.