793617 - implement mask-type property from CSS Masking

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: WIP (v0.1)

The initially proposed maskType="" attribute on <mask> morphed into a mask-type property that applies to <mask> elements last week during the SVG WG's F2F.  A WebKit implementation landed later that week (perhaps a record time between spec change and implementation appearing?): http://trac.webkit.org/changeset/129018

Attached is a WIP implementation.

David, can you give some guidance on what we should be doing here with prefixes?

Comment 1

[David Baron :dbaron:]

Comment on attachment 663963 [details] [diff] [review]
WIP (v0.1)

I think we should not prefix.  If WebKit-based browsers are shipping this, then it's fine for us to ship it too; if not, we probably want to put it behind a pref if the spec isn't stable yet.

Comment 2

[David Baron :dbaron:]

And you need to add to property_database.js and then make sure the layout/style mochitests pass.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch

r?longsonr for {content,layout}/svg/ changes, r?dbaron for the rest.  I've used layout.css.masking.enabled as the pref to put this behind, with the expectation that other things we implement from the CSS Masking specification go behind that pref too.

Comment 4

[Robert Longson [:longsonr]]

Comment on attachment 678965 [details] [diff] [review]
patch

I'd like to see a SMIL animation reftest too.

Comment 5

[David Baron :dbaron:]

Comment on attachment 678965 [details] [diff] [review]
patch

r=dbaron on the parts requested

Comment 6

[JP Rosevear [:jpr]]

Is there any reason not to land this?

Comment 7

[Cameron McCormack (:heycam)]

We just this morning had a telcon where we resolved some concerns about the naming of this property.  So I will be landing it today.

Comment 8

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e043d5feb0b6

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e043d5feb0b6

Comment 10

[Jean-Yves Perrier [:teoli]]

Documentation done:
https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type (with live sample)
and
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/20