793685 - Fix style issues in mozdevice

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

As a precursor to bug 793236 I fixed up some styling around mozdevice (e.g using 4 space indents instead of 2).

I separated different issues into different patches.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Use 4 space indentation

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.1 - Don't use reserved keywords as variable names

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.2 - dmADB duplicates getTestRoot from parent

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.3 - Use docstrings where applicable

I may have misunderstood the meaning of the "# external function" comments, so feel free to disregard this patch. In either case, most of the methods could still use some better doc strings.

Comment 5

[Andrew Halberstadt [:ahal]]

Pushed all four patches to try: https://tbpl.mozilla.org/?tree=Try&rev=0833f2763f8b

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 664060 [details] [diff] [review]
Patch 1.3 - Use docstrings where applicable

Try run looks good (two failures seem to be tegras that timed out)

Comment 7

[William Lachance (:wlach)]

Comment on attachment 664055 [details] [diff] [review]
Patch 1.0 - Use 4 space indentation

Looks good to me.

Comment 8

[William Lachance (:wlach)]

Comment on attachment 664056 [details] [diff] [review]
Patch 1.1 - Don't use reserved keywords as variable names

LGTM

Comment 9

[William Lachance (:wlach)]

Comment on attachment 664057 [details] [diff] [review]
Patch 1.2 - dmADB duplicates getTestRoot from parent

LGTM

Comment 10

[William Lachance (:wlach)]

Comment on attachment 664060 [details] [diff] [review]
Patch 1.3 - Use docstrings where applicable

LGTM. The mozdevice documentation IMO needs a big rethink but this is still an incremental improvement over what we had before.

Comment 11

[Andrew Halberstadt [:ahal]]

https://github.com/mozilla/mozbase/commit/4ec461e1bc76aef235049b68c678a2b6a133fc06
https://github.com/mozilla/mozbase/commit/5f86214c44465988412554b9bd3768221d8c6cdf
https://github.com/mozilla/mozbase/commit/e36f1224424c8ba6eef7a1798a3308fcada5f7cf
https://github.com/mozilla/mozbase/commit/5c80d19e721c4208d1136d4fabf239d4ebff5242