Last Comment Bug 793725 - [markup panel] Add a preview of the DOM tree (à la Sublime Text)
: [markup panel] Add a preview of the DOM tree (à la Sublime Text)
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Firefox 18
Assigned To: Paul Rouget [:paul]
: developer.tools
: J. Ryan Stinnett [:jryans] (use ni?)
Mentors:
Depends on:
Blocks: 794402
  Show dependency treegraph
 
Reported: 2012-09-24 08:30 PDT by Paul Rouget [:paul]
Modified: 2012-09-27 00:14 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Proof of concept (Scratchpad) (666 bytes, application/x-javascript)
2012-09-24 08:30 PDT, Paul Rouget [:paul]
no flags Details
Screenshot (165.04 KB, image/png)
2012-09-24 08:31 PDT, Paul Rouget [:paul]
no flags Details
v0.1 (8.91 KB, patch)
2012-09-25 06:45 PDT, Paul Rouget [:paul]
no flags Details | Diff | Splinter Review
v1 (9.46 KB, patch)
2012-09-25 09:34 PDT, Paul Rouget [:paul]
mratcliffe: review+
Details | Diff | Splinter Review

Description Paul Rouget [:paul] 2012-09-24 08:30:05 PDT
Created attachment 664082 [details]
Proof of concept (Scratchpad)
Comment 1 Paul Rouget [:paul] 2012-09-24 08:31:04 PDT
Created attachment 664083 [details]
Screenshot
Comment 2 Paul Rouget [:paul] 2012-09-25 06:45:50 PDT
Created attachment 664486 [details] [diff] [review]
v0.1
Comment 3 Paul Rouget [:paul] 2012-09-25 09:34:34 PDT
Created attachment 664546 [details] [diff] [review]
v1
Comment 4 Michael Ratcliffe [:miker] [:mratcliffe] 2012-09-26 01:39:21 PDT
Comment on attachment 664546 [details] [diff] [review]
v1

Review of attachment 664546 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on condition that:
- Default for devtools.inspector.markupPreview should be true (robcee agrees).
- Please log another bug to make the preview clickable and scrollable (via mousedown).

::: browser/app/profile/firefox.js
@@ +1014,5 @@
>  pref("devtools.inspector.htmlHeight", 112);
>  pref("devtools.inspector.htmlPanelOpen", false);
>  pref("devtools.inspector.sidebarOpen", false);
>  pref("devtools.inspector.activeSidebar", "ruleview");
> +pref("devtools.inspector.markupPreview", false);

Default should be true ... robcee agrees.
Comment 5 Paul Rouget [:paul] 2012-09-26 02:34:39 PDT
https://hg.mozilla.org/integration/fx-team/rev/b0ecba78eb7f
Comment 6 Tim Taubert [:ttaubert] 2012-09-27 00:14:32 PDT
https://hg.mozilla.org/mozilla-central/rev/b0ecba78eb7f

Note You need to log in before you can comment on or make changes to this bug.