793750 - After starting up the Marketplace app through FF Android in Open with app, then returning to FF Android and reaccessing marketplace.mozilla.org on a new tab, nothing happens

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Jason Smith [:jsmith]]

Steps:

1. On a clean Nightly build, go to marketplace.mozilla.org
2. Select open with app
3. Return back to FF Android
4. Open a new tab and go to marketplace.mozilla.org

Expected:

The open with app option should appear, along with marketplace.mozilla.org still opening in the new tab.

Actual:

No prompt appears. No content loads either.

Comment 1

[Aaron Train [:aaronmt]]

Easy to reproduce -- 

E/GeckoConsole(13631): [JavaScript Error: "TypeError: this.MARKETPLACE is undefined" {file: "chrome://browser/content/browser.js" line: 6320}]

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

There are a lot of async promises/callbacks here. Have to be careful with "this".

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Want a review?

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 664307 [details] [diff] [review]
Patch

Whoops. yep.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48b43bd3fb17

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/48b43bd3fb17

Comment 7

[Aaron Train [:aaronmt]]

Is Aurora affected?