793829 - no debug symbols for in-tree freetype

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8c267074d62

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8c267074d62

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 664190 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): me not thinking we'd need symbols when I wrote this configure goop
User impact if declined: no user impact, but developers will continue to have useless stacks in crash-stats
Testing completed (on m-c, etc.): on trunk for a week, useful stacks have let us fix several bugs
Risk to taking this patch (and alternatives if risky): no risks I can identify
String or UUID changes made by this patch: none

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Leaving this approval nom, we can make sure it lands post-merge on Oct 8th and gets into the first 17.0 beta

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Lukas, I was suggesting that we get this into 16 and 17.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 664190 [details] [diff] [review]
patch

Beta is representative enough that we should be able to make bugs actionable there (17), and we've already gone to build on 16 so it's unfortunately too late - fortunately this isn't too critical.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Setting tracking for 16, if there was a chemspill we would consider this for a ride-along.

Comment 8

[Justin Wood (:Callek)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cca9be386a29

Comment 9

[u279076]

Flagging as [qa-] since I don't believe this to be something QA needs to verify.