Closed
Bug 793844
Opened 12 years ago
Closed 12 years ago
crash in nsContentList::nsContentList on print preview
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: martijn.martijn, Assigned: roc)
References
Details
(Keywords: crash, regression, testcase)
Crash Data
Attachments
(2 files)
191 bytes,
text/html
|
Details | |
1.10 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-4776a369-9a2e-440d-8185-c15ed2120924 . ============================================================= 0 xul.dll nsContentList::nsContentList content/base/src/nsContentList.cpp:477 1 xul.dll NS_GetContentList content/base/src/nsContentList.cpp:278 2 xul.dll DocHasPrintCallbackCanvas layout/printing/nsPrintEngine.cpp:2406 3 xul.dll SubDocHashEnum content/base/src/nsDocument.cpp:6987 4 xul.dll PL_DHashTableEnumerate obj-firefox/xpcom/build/pldhash.cpp:715 5 xul.dll nsDocument::EnumerateSubDocuments content/base/src/nsDocument.cpp:6997 6 xul.dll DocHasPrintCallbackCanvas layout/printing/nsPrintEngine.cpp:2426 7 xul.dll nsPrintEngine::HasPrintCallbackCanvas layout/printing/nsPrintEngine.cpp:2444 8 xul.dll DocumentViewerImpl::PrintPreview layout/base/nsDocumentViewer.cpp:3745 9 xul.dll NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70 10 xul.dll XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:2405 STr: - Visit testcase, go to File->Print Preview
Comment 1•12 years ago
|
||
Here is the link to the other crashes showing up in crash stats: https://crash-stats.mozilla.com/report/list?signature=nsContentList::nsContentList%28nsINode*,%20int,%20nsIAtom*,%20nsIAtom*,%20bool%29
Comment 2•12 years ago
|
||
Regression window: 2012-09-04-03-05-12 -- 2012-09-05-03-05-55 "Bug 745025 - Implement CanvasElement.mozPrintCallback" seems likely
Blocks: 745025
status-firefox18:
--- → affected
tracking-firefox18:
--- → ?
Keywords: regression
OS: Windows NT → All
Hardware: x86 → All
Comment 3•12 years ago
|
||
uh, this should definitely block 18. Need to get this fixed asap or backout Bug 745025.
Assignee | ||
Comment 4•12 years ago
|
||
The null check is the right thing here; a document with no root element has no canvases :-).
Assignee: nobody → roc
Attachment #664448 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #664448 -
Flags: review?(bugs) → review+
Updated•12 years ago
|
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4927e7e7477e
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4927e7e7477e
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment 7•12 years ago
|
||
There is only one crash in a post-fix Aurora 18 build: https://crash-stats.mozilla.com/report/list?query_search=signature&query_type=contains&reason_type=contains&range_value=4&range_unit=weeks&hang_type=any&process_type=any&signature=nsContentList%3A%3AnsContentList%28nsINode%2A%2C%20int%2C%20nsIAtom%2A%2C%20nsIAtom%2A%2C%20bool%29 The crash doesn't seem to be the same though, when looking through the stack trace.
Comment 8•12 years ago
|
||
The bug didn't reproduce for me with the steps in comment 0, so I couldn't verify the fix like that too. If it does reproduce for anyone else, please try to see if the crash still occurs.
Comment 9•11 years ago
|
||
Crash test: https://hg.mozilla.org/integration/mozilla-inbound/rev/42e2e31dd3a5
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•