Closed Bug 793844 Opened 13 years ago Closed 13 years ago

crash in nsContentList::nsContentList on print preview

Categories

(Core :: Layout, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla18
Tracking Status
firefox18 + verified

People

(Reporter: martijn.martijn, Assigned: roc)

References

Details

(Keywords: crash, regression, testcase)

Crash Data

Attachments

(2 files)

Attached file testcase
This bug was filed from the Socorro interface and is report bp-4776a369-9a2e-440d-8185-c15ed2120924 . ============================================================= 0 xul.dll nsContentList::nsContentList content/base/src/nsContentList.cpp:477 1 xul.dll NS_GetContentList content/base/src/nsContentList.cpp:278 2 xul.dll DocHasPrintCallbackCanvas layout/printing/nsPrintEngine.cpp:2406 3 xul.dll SubDocHashEnum content/base/src/nsDocument.cpp:6987 4 xul.dll PL_DHashTableEnumerate obj-firefox/xpcom/build/pldhash.cpp:715 5 xul.dll nsDocument::EnumerateSubDocuments content/base/src/nsDocument.cpp:6997 6 xul.dll DocHasPrintCallbackCanvas layout/printing/nsPrintEngine.cpp:2426 7 xul.dll nsPrintEngine::HasPrintCallbackCanvas layout/printing/nsPrintEngine.cpp:2444 8 xul.dll DocumentViewerImpl::PrintPreview layout/base/nsDocumentViewer.cpp:3745 9 xul.dll NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70 10 xul.dll XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:2405 STr: - Visit testcase, go to File->Print Preview
Keywords: testcase
Regression window: 2012-09-04-03-05-12 -- 2012-09-05-03-05-55 "Bug 745025 - Implement CanvasElement.mozPrintCallback" seems likely
Blocks: 745025
Keywords: regression
OS: Windows NT → All
Hardware: x86 → All
uh, this should definitely block 18. Need to get this fixed asap or backout Bug 745025.
Attached patch fixSplinter Review
The null check is the right thing here; a document with no root element has no canvases :-).
Assignee: nobody → roc
Attachment #664448 - Flags: review?(bugs)
Attachment #664448 - Flags: review?(bugs) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
The bug didn't reproduce for me with the steps in comment 0, so I couldn't verify the fix like that too. If it does reproduce for anyone else, please try to see if the crash still occurs.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: