793937 - Change display order of app review history

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

Description

[Lisa Brewster [:adora]]

See http://adora.io/screens/app_history-20120924-181715.jpg

The order of these history items is all wiggedy wack.  Is my assumption correct that the current logic is that the latest version notes and notes to reviewer are on top, then the rest of the history is chronological? 

What I'd like to see is a pure chronological listing of all app submission and review activity.  So based on my assumed history of this app, the order would be:

1. the original version notes and notes to the reviewer (which would not have specified what we asked him to fix)
2. Andrew's rejection notes on 8/22
3. resubmission on 8/28 (I'm guessing that's what happened on this date)
4. the second set of version notes and notes to the reviewer (which WOULD be in reply to what we asked him to fix)
5. Andrew's second rejection on 8/29

This would capture the entire conversation between developer and reviewer, and make the history one million times easier to follow.

Comment 1

[Andrew Williamson [:eviljeff]]

Your assumption is correct - there is only one 'notes to reviewer' and 'versions notes' and they get changed each time so we can't see what they've changed from.  (

(Things get even more wacky on some of the apps where there are extra versions)

Comment 2

[Rob Hudson [:robhudson]]

I think a good solution here is to:

1. Fix the missing title and call it "Resubmission" or something.
2. Put the notes to reviewers on resubmit in this log message rather than overwriting the original notes to reviewers.

That will keep things chronological, not overwrite important historical data, and fix the missing title.

Comment 3

[Wil Clouser [:clouserw]]

sounds good

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/08d37c4 

This doesn't fix any historical data, but will fix future resubmissions and review history as mentioned in comment 2.

Comment 5

[krupa raj[:krupa]]

looks good to me.
verified fixed at https://marketplace-dev.allizom.org/reviewers/apps/review/packaged-mozillaball-%E3%82%87-3

Comment 6

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot