793950 - [b2g-bluetooth] Handle volume change in BluetoothHfpManager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 664346 [details] [diff] [review]
v1 patch

Review of attachment 664346 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok outside of comments.

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +14,5 @@
>  
>  #include "mozilla/Services.h"
> +#include "mozilla/dom/bluetooth/BluetoothTypes.h"
> +#include "nsContentUtils.h"
> +#include "nsIDOMDOMRequest.h"

Don't think this needs to be here?

@@ +41,5 @@
> +
> +  if (NS_FAILED(obs->AddObserver(sInstance, MOZSETTINGS_CHANGED_ID, false))) {
> +    NS_WARNING("Failed to add settings change observer!");
> +    return false;
> +  }

Shouldn't this be part of creation? We don't need to readd the observer every time we fetch, do we?

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v2 patch

Fixed the following items:

* Add observer in creation
* No include "nsIDOMDOMRequest.h"

Comment 4

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=1756513d8057

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f80cc2f44c27

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f80cc2f44c27