Closed Bug 793953 Opened 7 years ago Closed 7 years ago

Support autoconf2.13 installed through fink

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

fink puts the autoconf binary from its autoconf2.13-legacy package into a weird location to make sure it doesn't overwrite the new autoconf.  I have a patch to detect that situation in client.mk.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #664352 - Flags: review?(khuey)
fink is an alternative to things like homebrew on the mac: just another way to get/compile/install Unix-ish software on OS X.
(In reply to comment #2)
> What is fink?  Why do we care?

And it's better than the rest of them because it is based on Debian apt.  :-)

(And I happen to use it ;-)
Comment on attachment 664352 [details] [diff] [review]
Patch (v1)

I think fink is being dumb here, but ok, fine.
Attachment #664352 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/5668f229dc6a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Further cleanup requested by glandium: https://hg.mozilla.org/mozilla-central/rev/6b87b58ff491
(In reply to Ehsan Akhgari [:ehsan] from comment #7)
> Further cleanup requested by glandium:
> https://hg.mozilla.org/mozilla-central/rev/6b87b58ff491

And backed this out, since that was broken for reasons that are not clear to me.

https://hg.mozilla.org/mozilla-central/rev/a425ea4f16c9
Comment on attachment 664352 [details] [diff] [review]
Patch (v1)

We need this for comm-central too.
Attachment #664352 - Flags: review?(mbanner)
Comment on attachment 664352 [details] [diff] [review]
Patch (v1)

ok, r=me for comm-central.
Attachment #664352 - Flags: review?(mbanner) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.