Closed
Bug 793967
Opened 12 years ago
Closed 12 years ago
Refactor Proxy::getElementIfPresent()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
1.93 KB,
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
Proxy::getElementIfPresent() is hard to read.
|
Assignee | |
Comment 1•12 years ago
|
||
This patch refactors Proxy::getElementIfPresent(). This (a) fixes a "suggest brackets around assignment used as truth value" warning; (b) complies with the standard "no else after return" style, and (c) is much easier to read.
Attachment #664371 -
Flags: review?(ejpbruel)
|
|
Assignee | |
Comment 2•12 years ago
|
||
1.5 week review ping. This is a small patch, please review it soon! Thanks.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 664371 [details] [diff] [review] Refactor Proxy::getElementIfPresent(). Review of attachment 664371 [details] [diff] [review]: ----------------------------------------------------------------- Sorry this took so long. This is much clearer. Thanks!
Attachment #664371 -
Flags: review?(ejpbruel) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/29edec35dae2
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/29edec35dae2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•