793972 - Details button on crashreporter dialogue doesn't work

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[david.smitmanis]

To reproduce: get a crash, check the "Tell Mozilla" box, click on the "Details" button. Nothing happens.

Comment 1

[Scoobidiver (away)]

It's applicable to all channels including Release.

Comment 2

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/e61a169463c6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222095919
Bad:
http://hg.mozilla.org/mozilla-central/rev/49956e0cc0bb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222142417
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e61a169463c6&tochange=49956e0cc0bb

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/23fef78981b5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222034818
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4720524d2eab
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222045818
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=23fef78981b5&tochange=4720524d2eab


Suspected: 
4720524d2eab	Ted Mielczarek — bug 602565 - Make crashreporter client use Rich Edit 4.1 control to fix display of Indic scripts. r=ehsan

Comment 3

[Cork]

Just so that its said, wfm on linux, so it seams to be windows only.

Comment 4

[(not currently active) Ted Mielczarek]

That's not terribly surprising since each platform has its own separate UI implementation, but thanks for checking that.

Comment 5

[Vladan Djeric (:vladan)]

I'm still seeing this behavior

Comment 6

[Vladan Djeric (:vladan)]

(In reply to Vladan Djeric (:vladan) from comment #5)
> I'm still seeing this behavior

.. on Windows after every crash

Comment 7

[Vladan Djeric (:vladan)]

Attachment: Use a RichEdit v4.1 control in the "Details" dialog

I tested Ted's idea to use a RichEdit v4.1 control in this dialog. I can confirm it fixes the problem on Windows. We might want to uplift this fix.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 708846 [details] [diff] [review]
Use a RichEdit v4.1 control in the "Details" dialog

Review of attachment 708846 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for missing that. This is a trivial fix and I would support landing it on any branch.

Comment 9

[Vladan Djeric (:vladan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83be9ac1f2eb

Comment 10

[Vladan Djeric (:vladan)]

Comment on attachment 708846 [details] [diff] [review]
Use a RichEdit v4.1 control in the "Details" dialog

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 602565
User impact if declined: The "Details" button in the Crash Reporter dialog will not work
Testing completed (on m-c, etc.): Built locally and confirmed the "Details" button works again. mozilla-inbound tests passed
Risk to taking this patch (and alternatives if risky): None, if this patch does not work, the "Details" button will remain broken
String or UUID changes made by this patch: None

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/83be9ac1f2eb

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 708846 [details] [diff] [review]
Use a RichEdit v4.1 control in the "Details" dialog

I don't think we can 100% guarantee that the only possible regression here would be a still non-functioning button. This is a longstanding issue, and therefore does not require an urgent fix. We should be very cautious when making any changes to crash reporting. Please uplift to Aurora. Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7ae9da4c4e50

Comment 14

[Manuela Muntean [Away]]

Verified with Firefox 20 beta 2 (build ID: 20130227063501), on a Windows 7 64-bit machine.

To test this, I've done:

1) Install Crash me! add-on
2) Provoke a crash
3) Check the "Tell Mozilla" box
4) Click on the "Details" button. A dialog shows, providing the requested information

Comment 15

[Mihai Morar, (:MihaiMorar)]

Verified as Fixed on FF 21b6 on Windows 7 x64
20130430204233