794005 - [b2g-bluetooth] Broadcast dialer-related system message

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

For the following actions, we have to broadcast system message to dialer app:

  * Accept an incoming voice call (ATA)
  * Terminate a call (AT+CHUP)
  * Place a call to the last number dialed (AT+BLDN)

The topic of system message is "bluetooth-dialer-command", and the message will be like {"command":"ATA"}/{"command":"CHUP"}/{"command":"BLDN"}.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 664410 [details] [diff] [review]
v1 patch

Review of attachment 664410 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +67,5 @@
>  {
> +  mListener = nullptr;
> +  if (!mListener->StopListening()) {
> +    NS_WARNING("Failed to stop listening RIL");
> +  }

So you set it to null, then you call a function on it... ?

::: dom/bluetooth/BluetoothHfpManager.h
@@ +38,4 @@
>    int mCurrentVgs;
>    int mCurrentCallIndex;
>    int mCurrentCallState;
> +  BluetoothRilListener *mListener;

nsAutoPtr

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v2 patch

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 665227 [details] [diff] [review]
v2 patch

Review of attachment 665227 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +55,5 @@
> +  if (!mListener->StartListening()) {
> +    NS_WARNING("Failed to start listening RIL");
> +  }
> +
> +  if (!sHfpCommandThread) {

Not a blocker, but possibly for a followup: How many things are we going to be running through this thread? Seems like we could probably just create the thread when ringing otherwise.

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/try/rev/89e0c137c226

Comment 6

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d293910d01e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d293910d01e