794027 - Bugzilla should notify people attaching a patch that they need to request review

Status: RESOLVED DUPLICATE of bug 804708

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Jonathan Watt [:jwatt]]

One of the hurdles for people contributing code for the first time is that bugzilla doesn't do as good a job as it could of guiding them through the correct steps. One of the issues that seems to happen semi-frequently with new contributors is that they come along, fix something that has bugged them, slap it in a bug as a patch, and then move on, without realizing that if they don't request review then the patch is liable to sit there without attention indefinitely.

It would be great if when someone ticked the "patch" checkbox if a little notification box were to expand below the checkbox notifying them that they will need to request review, and linking them to the "owners" page in order to help them find a suitable reviewer.

Comment 1

[:glob ✱]

(In reply to Jonathan Watt [:jwatt] from comment #0)
> It would be great if when someone ticked the "patch" checkbox if a little
> notification box were to expand below the checkbox notifying them that they
> will need to request review

this bit is easy :)

> and linking them to the "owners" page in order to help them find a suitable reviewer.

i think this would be a stumbling block.. i don't think we have a page that has a decent map of reviewers by component; all i can find is the module owners page.  i'm more than happy to be wrong about this :)

Comment 2

[Jonathan Watt [:jwatt]]

I think https://wiki.mozilla.org/Modules/All would be the place to link them to. Maybe also mention to try the #introduction IRC channel if they have problems with that.

Comment 3

[:glob ✱]

(In reply to Jonathan Watt [:jwatt] from comment #2)
> I think https://wiki.mozilla.org/Modules/All would be the place to link them
> to.

i disagree -- that page is a wall of text and i doubt it would help someone who doesn't know to set the review flag select the correct person.

i think it would be better to wait for 'mach' to gain the ability to show suggested reviewers, and suggest newcomers to that (bug 774145).

Comment 4

[:glob ✱]

we're going to not allow people to submit review requests without a requestee.