794055 - Video app fails to start if thumbnail fails to generate

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[cajbir (:cajbir)]

Bug 759506 enables use of zero copy video decoding using the hardware decoder for videos. With the patches from that bug applied the video app no longer starts with the latest Gaia code due to an uncaught error when generating thumbnails for mp4 files.

STR:

1) Ensure an .mp4 is in /sdcard/Movies
2) Ensure bug 759506 and dependancies are applied
3) Start video app

Expected result:

4) sdcard is scanned and video list appears

Actual result:

4) Black screen

This is a regression from about a week ago. There used to be a try/catch around:

metadata.poster = captureFrame(previewPlayer);

in video.js. If the captureFrame failed then it would continue with no thumbnail for that video. Now if it fails and the video app no longer works.

Comment 1

[cajbir (:cajbir)]

Raised Gaia issue https://github.com/mozilla-b2g/gaia/issues/5142 about this.

Comment 2

[Dale Harvey (:daleharvey)]

This bug should be closed as its a gaia bug

The failure to generate the thumbnail is likely however a platform bug

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Fixed by gaia change.  We need to fix thumbnail generation separately.

Comment 4

[Diego Wilson [:diego]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Fixed by gaia change.  We need to fix thumbnail generation separately.

Is there a bug for this?

Comment 5

[Diego Wilson [:diego]]

Filed bug 798448