794066 - Impossible to drag & drop, rotate or resize elements in SVG generator demo

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[Loic]

It's a recent regression.

Open this SVG generator demo of coffee cup:
http://www.cross-cross-coffee-cup.com/
With your mouse, you are able to drag & drop various elements to decorate the coffee cup. Each element can be rotated or resized too (with the white dot on each element).

Result: it's impossible to do these actions in recent nightlies.
Restarting in safe mode, disabling HWA or setting javascript.options.ion.content to false don't fix the issue.

m-c
good=2012-09-22
bad=2012-09-23
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9cfb80a82883&tochange=9d285bedbc1f

Suspected bug (maybe):
Robert Longson — Bug 567848 - Split content methods from nsSVGUtils into SVGContentUtils. r=dholbert

Comment 1

[Alice0775 White]

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/8d077e0638d4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922122715
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/fcf9991c8d97
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922122915
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8d077e0638d4&tochange=fcf9991c8d97
Suspected : Bug 726615

Comment 2

[Robert Longson [:longsonr]]

Thanks so much Alice.

Comment 3

[Loic]

Thanks, component changed according to the bug blocked.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Is the site still checking for the old event names?  Do we even _have_ new event names?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Or is this basically like bug 794711?

Comment 6

[Jim Mathies [:jimm]]

(In reply to Boris Zbarsky (:bz) from comment #5)
> Or is this basically like bug 794711?

I haven't had a chance to try and reduce this one down yet, but is looks like they may all be the same problem.

Comment 7

[Jim Mathies [:jimm]]

This appears to be the code they are using:

http://modernizr.com/docs/#features-misc
http://modernizr.github.com/Modernizr/touch.html

Comment 8

[Jim Mathies [:jimm]]

Attachment: mondernizr touch test

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 665642 [details]
mondernizr touch test

So 'ontouchstart' in window is true in touch events enabled Gecko, right?

(DocumentTouch should not be in global scope)

Comment 10

[Jim Mathies [:jimm]]

(In reply to Olli Pettay [:smaug] from comment #9)
> Comment on attachment 665642 [details]
> mondernizr touch test
> 
> So 'ontouchstart' in window is true in touch events enabled Gecko, right?
> 
> (DocumentTouch should not be in global scope)

alert(('ontouchstart' in window?'true,':'false,')+window.DocumentTouch+','+(document instanceof DocumentTouch));

true,[object DocumentTouch],true

Comment 11

[Jim Mathies [:jimm]]

Also that's on a desktop that does not have a touch screen.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

But does have the pref enabled.

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

(and we should change nsIDOMDocumentTouch to nsIDocumentTouch. My bad.)

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

But anyhow, the page does probably something different when touch events are enabled.
Maybe it doesn't register listeners for mouse or drag events?

Comment 15

[Jim Mathies [:jimm]]

(In reply to Olli Pettay [:smaug] from comment #12)
> But does have the pref enabled.

right, we turned that on by default for Windows in the prefs module.

Comment 16

[Loic]

dom.w3c_touch_events.enabled = false fixes the issue.

Comment 17

[Jim Mathies [:jimm]]

I'm going to clone this off into a second bug. Aside from the weird behavior you see due tho the site's broken touch detection, on touch friendly devices drag and drop still doesn't work quite right. This might be the site, or it might related to our method of delivering w3c touch events. I'd like to make sure these events are working correctly and this site makes a good test case.

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Doesn't look like the website exists any more, I get redirected to some sort of pyramid scheme website.