Closed
Bug 794088
Opened 13 years ago
Closed 13 years ago
Menu: update icons, add submenu indicator
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox18 verified)
VERIFIED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox18 | --- | verified |
People
(Reporter: ibarlow, Assigned: sriram)
References
Details
Attachments
(2 files)
202.21 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
4.18 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Now that we have a working submenu system, we just need to update the icons, and add some kind of indicator for menu items that have submenus.
Mockup: http://cl.ly/image/0c0l400D460G
Assets are attached
Reporter | ||
Comment 1•13 years ago
|
||
Hm, assets wouldn't upload, here is a link to them: http://cl.ly/3V1R2C1r0b1G
Assignee | ||
Comment 2•13 years ago
|
||
This replaces icons, fixes the layout to move things a bit.
Attachment #665094 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #665094 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•13 years ago
|
||
We earlier have a small bevel that differentiated the menu from the page. The new plain color required a top shadow. Hence replacing it for the custom menu on phones with h/w menu button.
Attachment #665109 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #665109 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/56814cafb2ad
https://hg.mozilla.org/mozilla-central/rev/0378831600de
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Comment 6•13 years ago
|
||
Finally :-)
Status: RESOLVED → VERIFIED
status-firefox18:
--- → verified
OS: Mac OS X → Android
Hardware: x86 → ARM
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•