Closed Bug 794088 Opened 8 years ago Closed 8 years ago

Menu: update icons, add submenu indicator

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 18
Tracking Status
firefox18 --- verified

People

(Reporter: ibarlow, Assigned: sriram)

References

Details

Attachments

(2 files)

Now that we have a working submenu system, we just need to update the icons, and add some kind of indicator for menu items that have submenus.

Mockup: http://cl.ly/image/0c0l400D460G

Assets are attached
Hm, assets wouldn't upload, here is a link to them: http://cl.ly/3V1R2C1r0b1G
No longer blocks: 785994
Blocks: 785994
Attached patch PatchSplinter Review
This replaces icons, fixes the layout to move things a bit.
Attachment #665094 - Flags: review?(mark.finkle)
Attachment #665094 - Flags: review?(mark.finkle) → review+
Attached patch Patch (2/2)Splinter Review
We earlier have a small bevel that differentiated the menu from the page. The new plain color required a top shadow. Hence replacing it for the custom menu on phones with h/w menu button.
Attachment #665109 - Flags: review?(mark.finkle)
Attachment #665109 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/56814cafb2ad
https://hg.mozilla.org/mozilla-central/rev/0378831600de
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Finally :-)
Status: RESOLVED → VERIFIED
OS: Mac OS X → Android
Hardware: x86 → ARM
You need to log in before you can comment on or make changes to this bug.