794092 - Implement RecoveryService: an XPCOM service wrapper for librecovery

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marshall Culpepper [:marshall_law]]

This service will be needed for both factory reset and FOTA updates.

See initial librecovery here:
http://github.com/marshall/librecovery

Comment 1

[Marshall Culpepper [:marshall_law]]

Attachment: RecoveryService - v3

Updated patch for API suggested by cjones

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 664516 [details] [diff] [review]
RecoveryService - v3

Review of attachment 664516 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but i don't really like the idea of boolean that are always false.

::: b2g/components/RecoveryService.js
@@ +12,5 @@
> +
> +const RECOVERYSERVICE_CID = Components.ID("{b3caca5d-0bb0-48c6-912b-6be6cbf08832}");
> +const RECOVERYSERVICE_CONTRACTID = "@mozilla.org/recovery-service;1";
> +const DEBUG = true;
> +

DEBUG is never used.

::: b2g/components/b2g.idl
@@ +48,5 @@
> +   * successful, the device should reboot before the function call ever returns.
> +   *
> +   * @return false when rebooting into recovery fails for some reason.
> +   */
> +  boolean factoryReset();

Is there any reasons to return a boolean that is always false. I don't know if throwing errors is better here?

@@ +56,5 @@
> +   * successful, the device should reboot before the function call ever returns.
> +   *
> +   * @return false when rebooting into recovery fails for some reason.
> +   */
> +  boolean installFotaUpdate(in string updatePath);

Same comment as above.

Comment 3

[Marshall Culpepper [:marshall_law]]

Attachment: RecoveryService - v4

Asking for another review since I added a new FOTA update status checking API.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 665517 [details] [diff] [review]
RecoveryService - v4

This is a small enough change that I'm sure Vivien is happy to defer to me and get some sleep ;).

Comment 5

[Marshall Culpepper [:marshall_law]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c19a02de09c4

Comment 6

[Marshall Culpepper [:marshall_law]]

Follow up for asynchronous APIs: https://bugzilla.mozilla.org/show_bug.cgi?id=795512

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c19a02de09c4