Closed
Bug 794092
Opened 8 years ago
Closed 8 years ago
Implement RecoveryService: an XPCOM service wrapper for librecovery
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-basecamp:+)
RESOLVED
FIXED
blocking-basecamp | + |
People
(Reporter: marshall, Assigned: marshall)
References
Details
Attachments
(1 file, 1 obsolete file)
7.44 KB,
patch
|
cjones
:
review+
cjones
:
review+
|
Details | Diff | Splinter Review |
This service will be needed for both factory reset and FOTA updates. See initial librecovery here: http://github.com/marshall/librecovery
Assignee | ||
Comment 1•8 years ago
|
||
Updated patch for API suggested by cjones
Attachment #664516 -
Flags: review?(21)
Comment 2•8 years ago
|
||
Comment on attachment 664516 [details] [diff] [review] RecoveryService - v3 Review of attachment 664516 [details] [diff] [review]: ----------------------------------------------------------------- r+ but i don't really like the idea of boolean that are always false. ::: b2g/components/RecoveryService.js @@ +12,5 @@ > + > +const RECOVERYSERVICE_CID = Components.ID("{b3caca5d-0bb0-48c6-912b-6be6cbf08832}"); > +const RECOVERYSERVICE_CONTRACTID = "@mozilla.org/recovery-service;1"; > +const DEBUG = true; > + DEBUG is never used. ::: b2g/components/b2g.idl @@ +48,5 @@ > + * successful, the device should reboot before the function call ever returns. > + * > + * @return false when rebooting into recovery fails for some reason. > + */ > + boolean factoryReset(); Is there any reasons to return a boolean that is always false. I don't know if throwing errors is better here? @@ +56,5 @@ > + * successful, the device should reboot before the function call ever returns. > + * > + * @return false when rebooting into recovery fails for some reason. > + */ > + boolean installFotaUpdate(in string updatePath); Same comment as above.
Attachment #664516 -
Flags: review?(21) → review+
Updated•8 years ago
|
blocking-basecamp: ? → +
Assignee | ||
Comment 3•8 years ago
|
||
Asking for another review since I added a new FOTA update status checking API.
Attachment #664516 -
Attachment is obsolete: true
Attachment #665517 -
Flags: review?(jones.chris.g)
Attachment #665517 -
Flags: review?(21)
Attachment #665517 -
Flags: review?(jones.chris.g) → review+
Comment on attachment 665517 [details] [diff] [review] RecoveryService - v4 This is a small enough change that I'm sure Vivien is happy to defer to me and get some sleep ;).
Attachment #665517 -
Flags: review?(21) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c19a02de09c4
Assignee | ||
Comment 6•8 years ago
|
||
Follow up for asynchronous APIs: https://bugzilla.mozilla.org/show_bug.cgi?id=795512
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c19a02de09c4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•