Closed Bug 794194 Opened 7 years ago Closed 7 years ago

Talos local --results_url writing needs some newlines

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

I was thoroughly confused by some results files talos wrote for me:

START
VALUES
qm-pxp01,ts_places_generated_med,,2ec899b0cb5a,20120921091157,1348501218
0,2744.00,NULL
1,2320.00,NULL
2,2300.00,NULL
3,2331.00,NULL
4,2337.00,NULL
5,2329.00,NULL
6,2357.00,NULL
7,2336.00,NULL
8,2330.00,NULL
9,2366.00,NULL
10,2316.00,NULL
11,2350.00,NULL
12,2343.00,NULL
13,2363.00,NULL
14,2351.00,NULL
15,2324.00,NULL
16,2354.00,NULL
17,2322.00,NULL
18,2348.00,NULL
19,2307.00,NULL
ENDSTART
VALUES
qm-pxp01,ts_places_generated_med_shutdown,,2ec899b0cb5a,20120921091157,1348501218
...

until I realized that ENDSTART was meant to be *two* tokens, not one, due to a bug in the file-writing process.
Attached patch patchSplinter Review
Trivial patch.  I thought it was better to add this here than write "END\n" in the GraphserverOutput code.
Attachment #664603 - Flags: review?(jmaher)
Comment on attachment 664603 [details] [diff] [review]
patch

Review of attachment 664603 [details] [diff] [review]:
-----------------------------------------------------------------

this looks good, thanks!
Attachment #664603 - Flags: review?(jmaher) → review+
http://hg.mozilla.org/build/talos/rev/f1929696f66a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 801633
You need to log in before you can comment on or make changes to this bug.