794264 - [crontabber] matviews should record result and messages from all stored proc calls

Status: RESOLVED DUPLICATE of bug 855423

(Socorro :: Database, task)

Description

[Peter Bengtsson [:peterbe]]

At the moment matviews.py run() methods just call the stored procedures. 
Instead, it should listen to the output and if it's negative (e.g. FALSE) it should loudly log about it. 

Currently it looks like this::


    def run(self, connection):
        cursor = connection.cursor()
        cursor.callproc(self.get_proc_name())
        connection.commit()

It needs to look something like this::

    def run(self, connection):
        cursor = connection.cursor()
        cursor.callproc(self.get_proc_name())
        result, messages = cursor.fetchone()
        if result == 'false':
            logging.error(bla bla bla messages)
        connection.commit()

Comment 1

[Peter Bengtsson [:peterbe]]

In fact, log if there is *ANY* notice. (idea from Josh)

Comment 2

[Peter Bengtsson [:peterbe]]

See here, http://www.postgresql.org/docs/9.1/static/plpgsql-errors-and-messages.html
about how to use "RAISE NOTICE"

Comment 3

[Peter Bengtsson [:peterbe]]

Alternatively if the result is FALSE, then log louder (e.g. logging.warning instead of logging.info)

Comment 4

[[:jberkus] Josh Berkus]

create function test_notice ()
returns boolean
language plpgsql
as $f$
BEGIN

RAISE NOTICE 'I raised a notice';
RETURN FALSE;

END;
$f$;