794324 - [HiDPI] Images for the search engine editor

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: @2x icons - v1

2 @2x images in png format. Simply including the @2x images in the build allows this to work.

(brought to you by the department of [really low hanging fruit and the keyword ‘magic’]™)

Note: while working on this, I noticed that the darker grey bar at the bottom of the images differ in color (search_editor_action uses rgb(230,230,230) while search_editor_bottom_background uses rgb(235,235,235)). Is this intentional? The closest example at OS level is System Preferences, Users and Groups, and uses the same colors all over. Different colour values and more gradient-y, though, but this is Mountain Lion.

Comment 1

[philippe (part-time)]

Attachment: screenshot under HiDPI mode

Comment 2

[philippe (part-time)]

Hmm, this also needs a patch to tell the build process to include the images.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to philippe (part-time) from comment #0)
> Created attachment 664759 [details]
> @2x icons - v1
> 
> 2 @2x images in png format. Simply including the @2x images in the build
> allows this to work.
> 
> (brought to you by the department of [really low hanging fruit and the
> keyword ‘magic’]™)

This comment brought to you by the department of [really low hanging fruit and the keyword “quick”].

Given that this is going to need a project patch anyway to package the new images, I'd rather we just switch to single file multi-page tiffs for these two.  (I'm not sure why murph used .png to begin with; nothing in bug 201723 seems to indicate why, nor any explanation for your "Note" question.)

I believe (but haven't checked) the images are referenced in the nib simply by their name, so switching the extension should just work, and it should just be a s/png/tiff/g in the relevant lines in the project file (both the filename extension and the content-type).

Comment 4

[philippe (part-time)]

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #3)

> Given that this is going to need a project patch anyway to package the new
> images, I'd rather we just switch to single file multi-page tiffs for these
> two.  (I'm not sure why murph used .png to begin with; nothing in bug 201723
> seems to indicate why, nor any explanation for your "Note" question.)

Ok. I'll prepare tiff files - and use rgb(235,235,235) for the background strip all over (that seems the average all over 10.6 and 10.8 - System prefs, Mail prefs > accounts, except Xcode 4.4 which uses rgb(225,225,225).

(The difference between the 2 grays is hard to see, depending on the age and quality of the monitor, brightness settings, ambient light and the phase of the moon)
 
> I believe (but haven't checked) the images are referenced in the nib simply
> by their name, so switching the extension should just work, and it should
> just be a s/png/tiff/g in the relevant lines in the project file (both the
> filename extension and the content-type).

I checked the nib and indeed the images are just referenced by name (afaict, Xcode 4.4). Swapping in a test tiff file in the build works as expected. I'll investigate the project file edits.

Comment 5

[philippe (part-time)]

Attachment: icons v2

Combined icons as multipage tiff files.
The colour of the darker strip has been made consistent.

Comment 6

[philippe (part-time)]

Attachment: patch, project file

.tiff & image.tiff instead of .png & image.png

Comment 7

[philippe (part-time)]

Attachment: screenshot, combined lowdpi and hidpi

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 665757 [details]
icons v2

I like simple images like this; easy (and quick) to review ;-)  Nice and crisp! r/icon-sr=ardissone

At some point we'll want to switch to using the system image for the gear and composite it (I thought Stuart had a placeholder or metabug for that, but I can't find it), but not now.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 665759 [details] [diff] [review]
patch, project file

mento would probably yell at me for having you do it this way (since the file is strictly changing, not just normalizing the extension), but this is really the easiest way, given Xcode project file compatibility issues ;-)

r=ardissone, and thanks!

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/b38989cf949c

Hoping to get to at least one of the more time-consuming icon reviews tomorrow.