7944 - [onchange] Target not being set (plus the name should be onselect instead)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[lchiang]

[PP] Delete message results in a crash

Win32 1999-06-10 afternoon build
Scott Putterman was also seeing this in his debug build as reported in bug 6459.

1) Start Messenger and select Inbox
2) Select a message in the thread pane
3) Click Delete toolbar button
4) Crash occurs.

Talkback incident ID is: 9759317

Scott's stack trace is probably more useful than mine so here is Scott's which
I'm pasting in:

850cc483()
nsJSUtils::nsConvertObjectToJSVal(nsISupports * 0x00129e48, JSContext *
0x02fe34f0, long * 0x0012a564) line 133 + 20 bytes
GetEventProperty(JSContext * 0x02fe34f0, JSObject * 0x035b4528, long -3, long *
0x0012a564) line 101 + 17 bytes
js_GetProperty(JSContext * 0x02fe34f0, JSObject * 0x035b4528, long 51009360,
long * 0x0012a564) line 1694 + 72 bytes
js_Interpret(JSContext * 0x02fe34f0, long * 0x0012a6e4) line 2155 + 978 bytes
js_Invoke(JSContext * 0x02fe34f0, unsigned int 1, int 0) line 666 + 13 bytes
js_CallFunctionValue(JSContext * 0x02fe34f0, JSObject * 0x00e30130, long
14876992, unsigned int 1, long * 0x0012a828, long * 0x0012a830) line 735 + 15
bytes
JS_CallFunctionValue(JSContext * 0x02fe34f0, JSObject * 0x00e30130, long
14876992, unsigned int 1, long * 0x0012a828, long * 0x0012a830) line 2554 + 29
bytes
nsJSEventListener::HandleEvent(nsIDOMEvent * 0x037b74c0) line 97 + 34 bytes
nsEventListenerManager::HandleEvent(nsIPresContext & {...}, nsEvent *
0x0012a9e0, nsIDOMEvent * * 0x0012a9b4, unsigned int 3, nsEventStatus &
nsEventStatus_eIgnore) line 882 + 21 bytes
RDFElementImpl::HandleDOMEvent(RDFElementImpl * const 0x0311ba90, nsIPresContext
& {...}, nsEvent * 0x0012a9e0, nsIDOMEvent * * 0x0012a9b4, unsigned int 1,
nsEventStatus & nsEventStatus_eIgnore) line 2279
nsTreeFrame::FireChangeHandler(nsIPresContext & {...}) line 266
nsTreeFrame::RemoveFromSelection(nsIPresContext & {...}, nsTreeCellFrame *
0x03887a00) line 181
nsTreeCellFrame::DeleteFrame(nsTreeCellFrame * const 0x03887a00, nsIPresContext
& {...}) line 342
nsFrameList::DeleteFrames(nsIPresContext & {...}) line 29
nsContainerFrame::DeleteFrame(nsContainerFrame * const 0x03887b20,
nsIPresContext & {...}) line 82
nsFrameList::DeleteFrame(nsIPresContext & {...}, nsIFrame * 0x03887b20) line 115
nsTableRowGroupFrame::IR_RowRemoved(nsTableRowGroupFrame * const 0x037f4160,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, RowGroupReflowState &
{...}, unsigned int & 0, nsTableRowFrame * 0x03887b20) line 1329 + 19 bytes
nsTableRowGroupFrame::IR_TargetIsMe(nsTableRowGroupFrame * const 0x037f4160,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, RowGroupReflowState &
{...}, unsigned int & 0) line 1156 + 35 bytes
nsTableRowGroupFrame::IncrementalReflow(nsTableRowGroupFrame * const 0x037f4160,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, RowGroupReflowState &
{...}, unsigned int & 0) line 1086 + 31 bytes
nsTableRowGroupFrame::Reflow(nsTableRowGroupFrame * const 0x037f4164,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState &
{...}, unsigned int & 0) line 995 + 35 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x037f4160, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 392 + 28 bytes
nsTableFrame::IR_TargetIsChild(nsTableFrame * const 0x03121560, nsIPresContext &
{...}, nsHTMLReflowMetrics & {...}, InnerTableReflowState & {...}, unsigned int
& 0, nsIFrame * 0x037f4160) line 3582 + 34 bytes
nsTableFrame::IncrementalReflow(nsTableFrame * const 0x03121560, nsIPresContext
& {...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned
int & 0) line 3176 + 35 bytes
nsTableFrame::Reflow(nsTableFrame * const 0x03121564, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 2502 + 35 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x03121560, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 392 + 28 bytes
nsTableOuterFrame::IR_InnerTableReflow(nsTableOuterFrame * const 0x03121670,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, OuterTableReflowState &
{...}, unsigned int & 0) line 628 + 34 bytes
nsTableOuterFrame::IR_TargetIsInnerTableFrame(nsTableOuterFrame * const
0x03121670, nsIPresContext & {...}, nsHTMLReflowMetrics & {...},
OuterTableReflowState & {...}, unsigned int & 0) line 420 + 31 bytes
nsTableOuterFrame::IR_TargetIsChild(nsTableOuterFrame * const 0x03121670,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, OuterTableReflowState &
{...}, unsigned int & 0, nsIFrame * 0x03121560) line 392 + 31 bytes
nsTableOuterFrame::IncrementalReflow(nsTableOuterFrame * const 0x03121670,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, OuterTableReflowState &
{...}, unsigned int & 0) line 377 + 35 bytes
nsTableOuterFrame::Reflow(nsTableOuterFrame * const 0x03121674, nsIPresContext &
{...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned
int & 0) line 1027 + 35 bytes
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x03121670, const nsRect & {x=0 y=0
width=10035 height=1073741824}, int 1, int 0, int 1, nsMargin & {top=0 right=0
bottom=0 left=0}, unsigned int & 0) line 227 + 42 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox *
0x03130d10, int * 0x0012b6d4) line 2493 + 56 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x03130d10, int
* 0x0012b6d4) line 1983 + 20 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 1793 + 20 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x0311a4a4, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 1199 + 18 bytes
nsAreaFrame::Reflow(nsAreaFrame * const 0x0311a4a4, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 265 + 25 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x0311a4a0, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 392 + 28 bytes
RootFrame::Reflow(RootFrame * const 0x0311a664, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 229
nsContainerFrame::ReflowChild(nsIFrame * 0x0311a660, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 392 + 28 bytes
nsScrollFrame::Reflow(nsScrollFrame * const 0x03119174, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 423
nsContainerFrame::ReflowChild(nsIFrame * 0x03119170, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 392 + 28 bytes
ViewportFrame::Reflow(ViewportFrame * const 0x03119634, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 438
nsHTMLReflowCommand::Dispatch(nsHTMLReflowCommand * const 0x037b7720,
nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, const nsSize & {width=10275
height=4920}, nsIRenderingContext & {...}) line 169
PresShell::ProcessReflowCommands(PresShell * const 0x030556a0) line 1236
PresShell::ExitReflowLock(PresShell * const 0x030556a0) line 655
PresShell::ContentRemoved(PresShell * const 0x030556a8, nsIDocument *
0x0301e170, nsIContent * 0x037f49c0, nsIContent * 0x03855080, int 49) line 1688
XULDocumentImpl::ContentRemoved(XULDocumentImpl * const 0x0301e170, nsIContent *
0x037f49c0, nsIContent * 0x03855080, int 49) line 1948
RDFElementImpl::RemoveChildAt(RDFElementImpl * const 0x037f49c0, int 49, int 1)
line 1648
RDFTreeBuilderImpl::RemoveWidgetItem(nsIContent * 0x037f49c0, nsIRDFResource *
0x0301e590, nsIRDFResource * 0x0381c4f0) line 1331 + 18 bytes
RDFGenericBuilderImpl::OnUnassert(RDFGenericBuilderImpl * const 0x0311e734,
nsIRDFResource * 0x031e0370, nsIRDFResource * 0x0301e590, nsIRDFNode *
0x0381c4f0) line 1396 + 37 bytes
CompositeDataSourceImpl::OnUnassert(CompositeDataSourceImpl * const 0x0311b5c4,
nsIRDFResource * 0x031e0370, nsIRDFResource * 0x0301e590, nsIRDFNode *
0x0381c4f0) line 1201
nsMsgRDFDataSource::unassertEnumFunc(void * 0x0311b5c4, void * 0x0012e020) line
311
nsVoidArray::EnumerateForwards(int (void *, void *)* 0x012032a0
nsMsgRDFDataSource::unassertEnumFunc(void *, void *), void * 0x0012e020) line
213 + 20 bytes

Comment 1

[scottputterman]

I've decided to back out my use of "onchange" in threadPane.xul and use
"onclick" instead like I did before.  When these bugs are fixed I'll go back to
"onchange".  If you need an example, go to
mailnews/base/resources/content/threadPane.xul and change the tree's "onclick"
to "onchange".  Unfortunately, I'm still crashing on exit when I go back to
"onclick".

This allows me to delete a message.  This bug should still exist since if I go
back to "onchange" it will crash.

Comment 2

[lchiang]

Updating status whiteboard to reflect that it's ok this is in M8 since there is
a temporary fix to allow deletion of messages in M7.

Comment 3

[lchiang]

<updated qa contact name>

Comment 4

[fenella]

Win_Nt (1999-08-13-09 M9)
This problem has been fixed.

Comment 5

[David Hyatt]

Mailnews hasn't switched back to using onchange.  There's no reason to believe
this problem has been fixed.  Reopening.

Comment 6

[scottputterman]

Actually, I've been using onchange in the threadpane for a few weeks now.  So,
if the problem is gone, then this may have been fixed.

Comment 7

[David Hyatt]

I'm still not setting the target in the onchange.  I'll change the name of this
bug then so that I can leave it open.

Comment 8

[David Hyatt]

The target is now being set properly.

Comment 9

[fenella]

hyatt, please advise me how to verify this bug.
Thanks,
Fenella

Comment 10

[fenella]

David said this is code level. I am going to mark this verified.  Please let
me know if this is a problem.