794458 - Make unpack / unpack tests steps less verbose

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

Background to bug 765224: Many of the buildbot logs are extremely verbose even in the case of success, causing larger log sizes, thereby meaning slower TBPL parsing (and of late, timeouts) - as well as making it harder for someone to look at the log and ascertain what actually failed without trying a bunch of searches.

One place I think we can cut back is in unpack / unpack tests, ie:

{
========= Started unpack (results: 0, elapsed: 11 secs) (at 2012-09-26 06:28:19.787943) =========
...
Archive:  firefox-18.0a1.en-US.win32.zip
  inflating: firefox/AccessibleMarshal.dll  
  inflating: firefox/application.ini  
  inflating: firefox/blocklist.xml   
  inflating: firefox/breakpadinjector.dll  
  inflating: firefox/chrome.manifest  
 extracting: firefox/components/binary.manifest  
  inflating: firefox/components/browsercomps.dll  
  inflating: firefox/crashreporter-override.ini  
  inflating: firefox/crashreporter.exe  
  inflating: firefox/crashreporter.ini  
  inflating: firefox/D3DCompiler_43.dll  
  inflating: firefox/d3dx9_43.dll    
  inflating: firefox/defaults/pref/channel-prefs.js  
  inflating: firefox/dependentlibs.list  
  inflating: firefox/dictionaries/en-US.aff
...
}

and

{
========= Started unpack tests (results: 0, elapsed: 54 secs) (at 2012-09-26 06:28:46.095814) =========
...
Archive:  firefox-18.0a1.en-US.win32.tests.zip
  inflating: bin/certutil.exe        
  inflating: bin/components/httpd.js  
  inflating: bin/components/httpd.manifest  
  inflating: bin/components/test_necko.xpt  
  inflating: bin/crashinject.exe     
  inflating: bin/crashinjectdll.dll  
  inflating: bin/fix_stack_using_bpsyms.py  
  inflating: bin/pk12util.exe        
  inflating: bin/plugins/npsecondtest.dll  
  inflating: bin/plugins/nptest.dll  
  inflating: bin/screenshot.exe      
  inflating: bin/ssltunnel.exe       
  inflating: bin/vmwarerecordinghelper.dll  
  inflating: bin/xpcshell.exe        
  inflating: certs/bug483440-attack2b.ca  
  inflating: certs/bug483440-attack7.ca  
  inflating: certs/bug483440-pk10oflo.ca  
  inflating: certs/cert8.db          
}

Comment 1

[Ed Morley [:emorley]]

Attachment: buildbotcustom part

Comment 2

[Ed Morley [:emorley]]

Attachment: tools installdmg.sh part

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 664946 [details] [diff] [review]
buildbotcustom part

Cheers :-)

http://hg.mozilla.org/build/buildbotcustom/rev/97efa2a81346

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 664950 [details] [diff] [review]
tools installdmg.sh part

Thank you :-)

http://hg.mozilla.org/build/tools/rev/ab1e1ce9595f

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Did you check that none of these steps approach the 20 minute timeout where buildbot will kill the job without any output ?

Comment 6

[Ed Morley [:emorley]]

Yes, they're all under a minute.