794480 - Reader Mode not displaying whole article

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P3)

Description

[Karen Rudnitski [:kar]]

Attachment: Reader Mode not displaying full article

On my Asus Transformer Prime using Fx 16 Beta, went to http://southernfood.about.com/od/crockpotporkandham/r/r114c3b.htm (don't judge the recipe selection - although can tell you how it turns out later).

Pressed the Reader icon and it displayed in Reader mode.

ER: the whole article gets displayed
AR: only a portion of the recipe got displayed (see attached screen shot - that's scrolled down to the very bottom of the article)

Comment 1

[Karen Rudnitski [:kar]]

Attachment: reader mode not displaying properly

Comment 2

[Karen Rudnitski [:kar]]

another (cooking / baking) page where this happens. webpage: http://m.epicurious.com/recipes/food/views/Maple-Pumpkin-Pie-104200. Screen shot of 'reader mode' result attached. And for anyone interested, this is a great recipe.

Comment 3

[Alex Keybl [:akeybl]]

Is this a recent regression in the Reader Mode feature? If not, given where we are in the cycle, we won't be taking a fix for FF16. If this was a more prevalent issue in common use cases, we would have heard about it sooner.

Comment 4

[Brian Nicholson (:bnicholson)]

I've seen this on many (if not most) Wikipedia articles also. For example, http://en.wikipedia.org/wiki/Mountain_View,_CA and http://en.wikipedia.org/wiki/Mozilla_corporation both exhibit this problem.

Due to the way these pages are broken up, our reader mode parser has trouble distinguishing which blocks in the page are part of the article. I don't believe this is a regression.

Comment 5

[Alex Keybl [:akeybl]]

Wontfixing for FF16 because this missed our final beta.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

No one has piped up to call this a regression and with no one assigned it doesn't appear to be a Reader Mode priority.  Untracking for 17 but if a low-risk fix becomes known we'll consider for uplift to branches depending on timing during the cycle.

Comment 7

[:Margaret Leibovic]

(In reply to Karen Rudnitski [:kar] from comment #2)
> another (cooking / baking) page where this happens. webpage:
> http://m.epicurious.com/recipes/food/views/Maple-Pumpkin-Pie-104200. Screen
> shot of 'reader mode' result attached. And for anyone interested, this is a
> great recipe.

I don't even see the reader view button appear for this site, but article content for it does appear when I view this with readable-proxy, so it seems like something else is going wrong here.

However, when I load this in readable-proxy, I do see the ingredient list is missing, so we could focus on fixing that in this bug.

(In reply to Brian Nicholson (:bnicholson) from comment #4)
> I've seen this on many (if not most) Wikipedia articles also. For example,
> http://en.wikipedia.org/wiki/Mountain_View,_CA and
> http://en.wikipedia.org/wiki/Mozilla_corporation both exhibit this problem.

Both of these pages work for me.

Maybe something has changed since this bug was filed?

Comment 8

[Justin Dolske [:Dolske]]

Updating stale priorities to reflect priority in current reading list / reader view work.

(I see the issue reported in comment 0 -- the entire ingredient list is missing, and the reader view starts with "Preparation".)

Comment 9

[Justin Dolske [:Dolske]]

The reader view button no longer shows up with the recipes in comment 0 / comment 2.

I'm going to call this WFM (or arguably WONTFIX). I think recipe-like articles are going to be hard to support with reader view filter heuristics, because they're generally short bits of text (list of ingredients, a short paragraph or two of directions). That's hard to distinguish from a random web page with a few brief bits of text, which generally isn't useful to expose to reader view.