794491 - Try build without 'who' information fails on post_upload.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

Try build without 'who' information (eg. a staging build) fails when running post_upload.py since --who is specified but there is no argument.  It ends up looking something like this:

post_upload.py --who  --builddir /builds/foo/

Suggest we do one of:
(a) auto-fail a try build that is missing 'who' information
(b) pass a default value for who to post_upload.py, such as '[e-mail]'

Comment 1

[John Hopkins (:jhopkins)]

Attachment: proposed buildbotcustom patch

Successful staging try build ran without 'who' information and this patch.

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 665000 [details] [diff] [review]
proposed buildbotcustom patch

Review of attachment 665000 [details] [diff] [review]:
-----------------------------------------------------------------

Using [e-mail] as an email address will bounce eventually. But, we shouldn't be sending emails to try users in staging. Given that, sees reasonable to use [e-mail] as a username.

Comment 3

[John Hopkins (:jhopkins)]

Comment on attachment 665000 [details] [diff] [review]
proposed buildbotcustom patch

Landed in http://hg.mozilla.org/build/buildbotcustom/rev/12a3f375c0b0

Comment 4

[Aki Sasaki (not active)]

This is now live.