794514 - [b2g-bluetooth] Update OPP/HFP related DOM API

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

We need to add functions to nsIDOMBluetoothAdapter.idl for Gaia to connect/disconnect to remote device's service. For v1, we will implement connect and disconnect for both HFP & OPP, and provide another two functions sendFile and StopSendingFile for OPP.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: HFP/OPP related DOM API for v1

For v1, we'll have HFP and OPP in BT, and each profile can only have one connecting device, that's why I made Disconnect() can be called without device address.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: HFP/OPP related DOM API for V1

For v1, we'll have HFP and OPP in BT, and each profile can only have one connecting device, that's why I made Disconnect() can be called without device address.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v1: patch 2: implemented newly added functions

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 665497 [details] [diff] [review]
patch 1: v2: HFP/OPP related DOM API for V1

I'm not an sr :)

Comment 5

[Eric Chou [:ericchou] [:echou]]

(In reply to ben turner [:bent] from comment #4)
> Comment on attachment 665497 [details] [diff] [review]
> patch 1: v2: HFP/OPP related DOM API for V1
> 
> I'm not an sr :)

Oh, sorry. I thought you are. :)

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 665497 [details] [diff] [review]
patch 1: v2: HFP/OPP related DOM API for V1

Review of attachment 665497 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/nsIDOMBluetoothAdapter.idl
@@ +44,5 @@
>  
> +  // Profile ID
> +  const unsigned short HANDSFREE = 1;
> +  const unsigned short OBJECT_PUSH = 2;
> +  nsIDOMDOMRequest connect(in DOMString aDeviceAddress, in unsigned short aProfile);

Don't we have the UUIDs exposed to the DOM already? Can't we just use those? Just don't want to make yet another enum if we don't have to.

Comment 7

[Eric Chou [:ericchou] [:echou]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #6)
> Comment on attachment 665497 [details] [diff] [review]
> patch 1: v2: HFP/OPP related DOM API for V1
> 
> Review of attachment 665497 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bluetooth/nsIDOMBluetoothAdapter.idl
> @@ +44,5 @@
> >  
> > +  // Profile ID
> > +  const unsigned short HANDSFREE = 1;
> > +  const unsigned short OBJECT_PUSH = 2;
> > +  nsIDOMDOMRequest connect(in DOMString aDeviceAddress, in unsigned short aProfile);
> 
> Don't we have the UUIDs exposed to the DOM already? Can't we just use those?
> Just don't want to make yet another enum if we don't have to.

Make sense, but we haven't had exposed UUIDs yet, they are now living in BluetoothServiceUuid.h.

I'll remove these IDs stuff, then add comments to tell developers that aProfile is a 16-bits service uuid defined in section "Service classes and Profile Identifiers" in Bluetooth Assigned Numbers[1].

Another review for patch 2 will be needed because the logic will be slightly changed.

[1] https://www.bluetooth.org/Technical/AssignedNumbers/service_discovery.htm

Comment 8

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v3: HFP/OPP related DOM API for V1, r=qdot, sr=mrbkap

No method changed. Just removed unnecessary profile IDs.

Comment 9

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v2: Implementation

Comment 10

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 3: v1: Completed IPC call flow

Comment 11

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=c0ca584b91c3

Comment 12

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99e4fc2c74ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/36d770df9bc6
https://hg.mozilla.org/integration/mozilla-inbound/rev/81b8598fb470

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/99e4fc2c74ef
https://hg.mozilla.org/mozilla-central/rev/36d770df9bc6
https://hg.mozilla.org/mozilla-central/rev/81b8598fb470

Should this have tests?