Closed Bug 794514 Opened 7 years ago Closed 7 years ago

[b2g-bluetooth] Update OPP/HFP related DOM API

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: echou, Assigned: echou)

References

Details

(Whiteboard: [LOE:S])

Attachments

(3 files, 3 obsolete files)

We need to add functions to nsIDOMBluetoothAdapter.idl for Gaia to connect/disconnect to remote device's service. For v1, we will implement connect and disconnect for both HFP & OPP, and provide another two functions sendFile and StopSendingFile for OPP.
Assignee: nobody → echou
blocking-basecamp: --- → ?
Whiteboard: [LOE:S]
blocking-basecamp: ? → +
For v1, we'll have HFP and OPP in BT, and each profile can only have one connecting device, that's why I made Disconnect() can be called without device address.
Attachment #665496 - Flags: superreview?(bent.mozilla)
Attachment #665496 - Flags: review?(kyle)
For v1, we'll have HFP and OPP in BT, and each profile can only have one connecting device, that's why I made Disconnect() can be called without device address.
Attachment #665496 - Attachment is obsolete: true
Attachment #665496 - Flags: superreview?(bent.mozilla)
Attachment #665496 - Flags: review?(kyle)
Attachment #665497 - Flags: superreview?(bent.mozilla)
Attachment #665497 - Flags: review?(kyle)
Comment on attachment 665497 [details] [diff] [review]
patch 1: v2: HFP/OPP related DOM API for V1

I'm not an sr :)
Attachment #665497 - Flags: superreview?(bent.mozilla) → superreview?(mrbkap)
(In reply to ben turner [:bent] from comment #4)
> Comment on attachment 665497 [details] [diff] [review]
> patch 1: v2: HFP/OPP related DOM API for V1
> 
> I'm not an sr :)

Oh, sorry. I thought you are. :)
Comment on attachment 665497 [details] [diff] [review]
patch 1: v2: HFP/OPP related DOM API for V1

Review of attachment 665497 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/nsIDOMBluetoothAdapter.idl
@@ +44,5 @@
>  
> +  // Profile ID
> +  const unsigned short HANDSFREE = 1;
> +  const unsigned short OBJECT_PUSH = 2;
> +  nsIDOMDOMRequest connect(in DOMString aDeviceAddress, in unsigned short aProfile);

Don't we have the UUIDs exposed to the DOM already? Can't we just use those? Just don't want to make yet another enum if we don't have to.
Attachment #665497 - Flags: review?(kyle) → review+
Attachment #665498 - Flags: review?(kyle) → review+
Attachment #665497 - Flags: superreview?(mrbkap) → superreview+
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #6)
> Comment on attachment 665497 [details] [diff] [review]
> patch 1: v2: HFP/OPP related DOM API for V1
> 
> Review of attachment 665497 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bluetooth/nsIDOMBluetoothAdapter.idl
> @@ +44,5 @@
> >  
> > +  // Profile ID
> > +  const unsigned short HANDSFREE = 1;
> > +  const unsigned short OBJECT_PUSH = 2;
> > +  nsIDOMDOMRequest connect(in DOMString aDeviceAddress, in unsigned short aProfile);
> 
> Don't we have the UUIDs exposed to the DOM already? Can't we just use those?
> Just don't want to make yet another enum if we don't have to.

Make sense, but we haven't had exposed UUIDs yet, they are now living in BluetoothServiceUuid.h.

I'll remove these IDs stuff, then add comments to tell developers that aProfile is a 16-bits service uuid defined in section "Service classes and Profile Identifiers" in Bluetooth Assigned Numbers[1].

Another review for patch 2 will be needed because the logic will be slightly changed.

[1] https://www.bluetooth.org/Technical/AssignedNumbers/service_discovery.htm
No method changed. Just removed unnecessary profile IDs.
Attachment #665497 - Attachment is obsolete: true
Attachment #665498 - Attachment is obsolete: true
Attachment #665817 - Flags: review?(kyle)
Attachment #665817 - Flags: review?(kyle) → review+
Attachment #665902 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/99e4fc2c74ef
https://hg.mozilla.org/mozilla-central/rev/36d770df9bc6
https://hg.mozilla.org/mozilla-central/rev/81b8598fb470

Should this have tests?
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.