Closed
Bug 794520
Opened 12 years ago
Closed 12 years ago
Replace string.contains with string.endsWith in formatValue
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 18
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
From https://bugzilla.mozilla.org/show_bug.cgi?id=781588#c41,
> Comment on attachment 663537 [details] [diff] [review]
> Patch v6
>
> >+ if (!domain.contains(baseDomain)) {
> Should this be endsWith?
I tested this out and the browser_urlHighlight.js test still passes.
Attachment #665032 -
Flags: review?(felipc)
|
||
Updated•12 years ago
|
Attachment #665032 -
Flags: review?(felipc) → review+
|
|
||
Updated•12 years ago
|
Component: Tabbed Browser → Location Bar
|
Assignee | |
Comment 1•12 years ago
|
||
Thanks for the quick review Dao!
https://hg.mozilla.org/integration/mozilla-inbound/rev/be63bddab58b
Flags: in-testsuite+
|
||
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
You need to log in
before you can comment on or make changes to this bug.
Description
•