Closed Bug 794520 Opened 8 years ago Closed 8 years ago

Replace string.contains with string.endsWith in formatValue

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 18

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
From https://bugzilla.mozilla.org/show_bug.cgi?id=781588#c41,
> Comment on attachment 663537 [details] [diff] [review]
> Patch v6
> 
> >+              if (!domain.contains(baseDomain)) {
> Should this be endsWith?

I tested this out and the browser_urlHighlight.js test still passes.
Attachment #665032 - Flags: review?(felipc)
Attachment #665032 - Flags: review?(felipc) → review+
Component: Tabbed Browser → Location Bar
Thanks for the quick review Dao!

https://hg.mozilla.org/integration/mozilla-inbound/rev/be63bddab58b
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/be63bddab58b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
You need to log in before you can comment on or make changes to this bug.